Re: [SSHGuard-users] Call for testing: SSHGuard 1.7.0

[Kevin Z. <kev...@gm...>]

On 07/28/2016 10:27, Georg Lehner wrote:
> - The sshg-fw script stops with syntax error, a patch with some
>   improvements (hopefully) is attached.

What's the purpose of the 'x' in lines like these?

if [ "x$2" = "x6" ]; then

Since the string literals are provided, there shouldn't be an error when
the provided strings are empty. Isn't the 'x' there to guard against an
empty string?

> - Shortly after startup the following error message is shown,
>   processing continues
> 
>     sh: 1: exec: NONE/libexec/sshg-fw: not found

Working on this one.

> - After some processing sshguard stops because of a broken pipe.
>   See the attached sshguard.log for the error messages.
> 
> My guess: sshg-fw is not run (first error), and when the first attacker
> should be added the half-open pipe breaks.

Should be fixed in 'master' now.

> I noticed, that the sshg-fw script is wrapped together by './configure'
> and not by 'make'.  To rebuild it, you need to 'make distclean' and than
> './configure' again.  I propose either to build the script with make, or
> document the procedure.

I agree. I'll see what I can do. The main issue is that the Makefiles
don't know what firewall backend you chose.

Best,
Kevin

-- 
Kevin Zheng
kev...@gm... | ke...@be... | PGP: 0xC22E1090