From: Willem J. W. <wj...@di...> - 2016-01-04 22:36:29
|
On 01/04/2016 12:13, Mark Felder wrote: On 4-1-2016 21:33, Kevin Zheng wrote: >>> - Remove PID file option >> >> ... Why? The rc scripts on FreeBSD heavily rely on pidfiles. It ensures >> that the process name and pidfile contents match what it finds in the >> process list to be sure it's not going to kill the wrong process. I can >> alter sshguard's rc script to launch via daemon(8) so I can get a >> pidfile again, but that seems silly. > > I removed it thinking that I was duplicating what daemon(8) does. The > original PID file code did not properly lock the PID file, so I thought > to delegate to daemon(8) instead of rolling my own pidfile(3). I did not have time to react to the release notes before, but I have to concur with Mark that it is a pitty that this feature was removed. Does not make FreeBSD life much easier. And I'm not sure that the PIDfile needs to be locked. Why should it be? --WjW |