Re: [Sshguard-maintainers] [Sshguard-users] SSHGuard 1.6.3 release announcement

[Kevin Z. <kev...@gm...>]

On 01/04/2016 12:13, Mark Felder wrote:
>>     - Fix `pfctl` command syntax with OpenBSD 5.8
> 
> Does this in any way affect pf on FreeBSD?

No. This patch simply changes the order of the flags on the command line
to match the order documented in the `pf` man page, which is the same on
both FreeBSD and OpenBSD. OpenBSD 5.8 stopped accepting the flags in the
wrong order, but the right order works on both.

>>     - Remove PID file option
> 
> ... Why? The rc scripts on FreeBSD heavily rely on pidfiles. It ensures
> that the process name and pidfile contents match what it finds in the
> process list to be sure it's not going to kill the wrong process. I can
> alter sshguard's rc script to launch via daemon(8) so I can get a
> pidfile again, but that seems silly.

I removed it thinking that I was duplicating what daemon(8) does. The
original PID file code did not properly lock the PID file, so I thought
to delegate to daemon(8) instead of rolling my own pidfile(3).

Best,
Kevin

-- 
Kevin Zheng
kev...@gm... | ke...@kd... | PGP: 0xC22E1090