Re: [Sshguard-users] compiler warnings -D_XOPEN_SOURCE

[mij <mi...@ss...>]

> 
> Here's what the Open Group has to say [1]:
> 
> "An XSI-conforming application should ensure that the feature test macro
> _XOPEN_SOURCE is defined with the value 600 before inclusion of any header."
> 
>> So what do we think is safer ? Remove _XOPEN_SOURCE or add  || LINUX to
>> the solaris conditional?
> 
> I think the standard is pretty clear about unconditionally setting
> _XOPEN_SOURCE to 600. I've attached a patch that does just that. If
> there are no objections I'll commit it.

A radical change like switching feature test macros should be tested before
committing. It doesn’t always work as expected.


> Note that this is the only source directory that sets _XOPEN_SOURCE;
> should the others too?

All should, but careful what Automake inherits.

-m