Re: [Sshguard-users] 1.5rc4 under FreeBSD 8.1

[Mij <mi...@ss...>]

Hi John

On Oct 26, 2010, at 18:34 , John Vinopal wrote:

> Hi, thanks for the helpful application.  I've built a FreeBSD port for 1.5rc4 and have been running it for several days.
>  
> Here are the few issues I've noticed:
>  
> -v reports 1.4.4

updated in r218, as 1.5 is being released soon


> -i path-to-pidfile not documented in sshguard.8

committed in r219, thanks


> start of process doesn't print startup log message (FreeBSD std syslog.conf)
>     - uses LOG_INFO, should probably use LOG_NOTICE

I see no reasons against this: committed as r220


> no option to daemonize on start?

any problem doing it from the start script? The shell can do that easily.


> missing log message to indicate end of blocking (FreeBSD std syslog.conf)
>     - block and unblock should probably use same logging level
>     - currently block uses LOG_NOTICE and unblock LOG_INFO

I believe block is quite more important than unblock. Block is the apex of an attack,
whereas unblock is only a technical req for avoiding "trapping" addresses.


> kill of sshguard process yields log message:
> Oct 25 16:29:02 gabriella sshguard[42655]: Got CONTINUE signal, resuming activity.

The logic looks sane there (sshguard.c:197), are you sending a SIGCONT?