Re: [Sshguard-users] Found a bug in latest svn repository

[Mij <mi...@ss...>]

Thanks for insisting so kindly, you got it committed as r200 (!!) as a prize.


On May 21, 2010, at 22:57 , El Topo wrote:

> Hi,
> 
> I reported this bug before and it was fixed, but there is a leftover, so I am submitting a patch:
> 
> ===begin
> 
> Index: src/fwalls/hosts.c
> ===================================================================
> --- src/fwalls/hosts.c    (revision 199)
> +++ src/fwalls/hosts.c    (working copy)
> @@ -170,7 +170,6 @@
>  
>  int hosts_updatelist() {
>      char buf[HOSTS_MAXCMDLEN];
> -    char tempflname[30];
>      FILE *tmp, *deny;
>  
>      /* open hosts.allow file */
> 
> ===end
> 
> the patch is also attached.
> 
> Thanks,
> 
> cameos
> 
> On Thu, Mar 11, 2010 at 2:13 PM, El Topo <ca...@gm...> wrote:
> Hi,
> 
> I found a bug in 
> src/fwalls/hosts.c
> 
> 1. there is a global variable tempflname, but in fw_init() and hosts_updatelist(), local variables with the same name are also defined, this caused make_temporary_conffile() always fails. Fix: local variables should be deleted;
> 2. the glboal variable tempflname should be initialized as soon as possible in fw_init(), otherwise hosts_clearsshguardblocks() tries to create temp file with invalid name (and fails).
> 
> cameos
> 
> <sshguard.patch>------------------------------------------------------------------------------
> 
> _______________________________________________
> Sshguard-users mailing list
> Ssh...@li...
> https://lists.sourceforge.net/lists/listinfo/sshguard-users