Re: [Ssh-sftp-perl-users] [PATCH] Net::SSH2: A couple fixes for scp_get
Brought to you by:
dbrobins
From: David R. <dbr...@cp...> - 2006-05-17 02:59:54
|
On Friday May 12, 2006 22:01, Stephen Clouse wrote: > Two minor fixes to scp_get. I actually did these quite a while ago, > but they've been rolled into our local RPM repository and I forgot > about passing them along: > > 1. $stat{mode} gets anded with 0x777, which doesn't make any sense. > This was causing us some weird permission problems on retrieved files. > I think the intended number here is 0777 (octal). > > 2. The output handle for scp_get should probably have O_TRUNC set, > because I think this is what people expect. We found this from > getting errors about junk data at the end of tar files we were pulling > down, because we maintain a local cache and sometimes pull down the > same file multiple times and overwrite the local file. If the updated > file was smaller than the previous, the difference would remain at the > end of the new local file. Thanks again; applied to 0.09 candidate. -- Dave Isa. 40:31 |