[sserver-bugs] [ sserver-Bugs-1720067 ] problems with the play mode penalty kick

[SourceForge.net <no...@so...>]

Bugs item #1720067, was opened at 2007-05-16 23:40
Message generated for change (Settings changed) made by akym
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=380760&aid=1720067&group_id=24184

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Server
Group: None
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: dherfert (dherfert)
Assigned to: Nobody/Anonymous (nobody)
Summary: problems with the play mode penalty kick

Initial Comment:
We found three problems in the implementation of the penalty kicks. 


1.
The first issue concerns the positioning restrictions in playmode 'penalty_setup'.
It arises if 'pen_coach_moves_players' is set to 'false'. Even if both teams obey the positioning rules for 'penalty_setup' the referee decides for 'penalty_miss' immediately after switching to
playmode 'penalty_ready'.

2.
The second issue concerns the positioning restrictions in playmode 'penalty_taken'
(using'pen_coach_moves_players'='true').
After the executing player of the attacking team touched the ball and 'penalty_taken' is given, all the players of the defending team are allowed to leave the center circle.Thus 10 additional players can interfere in the penalty execution and bug the penalty striker.

3.
The third issue concerns the action restrictions in playmode 'penalty_taken'.Again consider the play mode is switched to 'penalty_taken' after the
striker touched the ball for the first time.
Since the ball is placed on ([+|-]10.0,0.0) other players can manipulate the ball even if they are positioned correctly within the center circle.
A player that is located near the ball can easily tackle the ball if the striker kicked the ball only slightly.

We reviewed the corresponding source code (in referee.cc) and corrected the first two issues.
For the second bug, players that try to leave the center circle illegally were reset to a legal position immediately.

  

----------------------------------------------------------------------

Comment By: Hidehisa Akiyama (akym)
Date: 2007-05-21 20:06

Message:
Logged In: YES 
user_id=595484
Originator: NO

Thanks for your report and patch.
I've merged your patch and released the release candidates. 
I hope all problems you reported are solved.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=380760&aid=1720067&group_id=24184