[srvx-commits] commit: Fix nick length check in is_valid_nick().

[Michael P. <md...@tr...>]

Revision: srvx--devo--1.3--patch-83
Archive: sr...@sr...--2004-srvx
Creator: Michael Poole <md...@tr...>
Date: Tue Nov  9 20:25:53 EST 2004
Standard-date: 2004-11-10 01:25:53 GMT
Modified-files: ChangeLog src/proto-p10.c
New-patches: sr...@sr...--2004-srvx/srvx--devo--1.3--patch-83
Summary: Fix nick length check in is_valid_nick().
Keywords: 

The for() loop in is_valid_nick() leaves 'nick' as an empty string,
which is obviosly shorter than the nick length limit.  Fix that.

* added files

    {arch}/srvx/srvx--devo/srvx--devo--1.3/sr...@sr...--2004-srvx/patch-log/patch-83

* modified files

--- orig/ChangeLog
+++ mod/ChangeLog
@@ -2,6 +2,20 @@
 # arch-tag: aut...@sr...--2004-srvx/srvx--devo--1.3
 #
 
+2004-11-10 01:25:53 GMT	Michael Poole <md...@tr...>	patch-83
+
+    Summary:
+      Fix nick length check in is_valid_nick().
+    Revision:
+      srvx--devo--1.3--patch-83
+
+    The for() loop in is_valid_nick() leaves 'nick' as an empty string,
+    which is obviosly shorter than the nick length limit.  Fix that.
+
+    modified files:
+     ChangeLog src/proto-p10.c
+
+
 2004-10-16 21:14:11 GMT	Michael Poole <md...@tr...>	patch-82
 
     Summary:


--- orig/src/proto-p10.c
+++ mod/src/proto-p10.c
@@ -1847,12 +1847,13 @@
 
 int
 is_valid_nick(const char *nick) {
+    unsigned int ii;
     /* IRC has some of The Most Fucked-Up ideas about character sets
      * in the world.. */
     if (!isalpha(*nick) && !strchr("{|}~[\\]^_`", *nick))
         return 0;
-    for (++nick; *nick; ++nick)
-        if (!isalnum(*nick) && !strchr("{|}~[\\]^-_`", *nick))
+    for (ii = 0; nick[ii]; ++ii)
+        if (!isalnum(nick[ii]) && !strchr("{|}~[\\]^-_`", nick[ii]))
             return 0;
     if (strlen(nick) > nicklen)
         return 0;