[srvx-bugs] [ srvx-Bugs-3606964 ] Possible memory leak with CSEARCH

[SourceForge.net <no...@so...>]

Bugs item #3606964, was opened at 2013-03-05 11:34
Message generated for change (Tracker Item Submitted) made by secretagentj
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=403001&aid=3606964&group_id=31654

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: OperServ
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jason (secretagentj)
Assigned to: Entrope (entrope)
Summary: Possible memory leak with CSEARCH

Initial Comment:
Not sure if you prefer SF or GitHub, so I'll just stick this here?

Possible memory leak when using CSEARCH and not providing arguments for criteria. In opserv_cdiscrim_create(), line ~3648:

        if (i == (argc - 1)) {
            send_message(user, opserv, "MSG_MISSING_PARAMS", argv[i]);
            return NULL;
        }

It simply returns NULL and doesn't free discrim, instead of jumping to fail and cleaning up first.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=403001&aid=3606964&group_id=31654