[srvx-bugs] [ srvx-Bugs-3439987 ] HelpServ: wrong responses for persist settings

[SourceForge.net <no...@so...>]

Bugs item #3439987, was opened at 2011-11-18 09:31
Message generated for change (Tracker Item Submitted) made by zerofighte
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=403001&aid=3439987&group_id=31654

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: HelpServ
Group: 1.4
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: ZeRoFiGhter (zerofighte)
Assigned to: Entrope (entrope)
Summary: HelpServ: wrong responses for persist settings

Initial Comment:
Hi,

in commit 671a213e001f8317536101c7ea63cb0e6de04175 ("Fix the name and type of helpserv_bot.persist_types[].") you made a minor mistake:

in opt_persist (line 3205 in current git master) there is:
helpserv_notice(user, persistence_lengths[idx].print_name,
                     user_find_message(user, persistence_lengths[hs->persist_lengths[idx]].print_name));

but it should be:
helpserv_notice(user, persistence_types[idx].print_name,
                     user_find_message(user, persistence_lengths[hs->persist_lengths[idx]].print_name));

2nd parameter should be persistence_types instead of persistence_lengths

visible effect of this bug is that HelpServ replies just the text like "part" or "quit" for the persist types, instead of "ReqPersist part" and alike.

regards,
ZeRoFiGhter

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=403001&aid=3439987&group_id=31654