[srvx-bugs] [ srvx-Bugs-3081638 ] override vs chanserv.trim

[SourceForge.net <no...@so...>]

Bugs item #3081638, was opened at 2010-10-05 21:47
Message generated for change (Tracker Item Submitted) made by zerofighte
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=403001&aid=3081638&group_id=31654

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: ChanServ
Group: 1.4
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: ZeRoFiGhter (zerofighte)
Assigned to: Entrope (entrope)
Summary: override vs chanserv.trim

Initial Comment:
hi,

we just noticed some strange behaviour:
helper with +g does a chanserv.trim while not having access at all.
general command handling allows to execute the command (due to +g) and logs as override
cmd_trim_users internally uses GetChannelAccess to check if the actor is allowed to trim which fails (as this does not check for +g, GetChannelUser should be used, imho, this checks for +g)
so cmd_trim_users msgs "you lack sufficient access" to the actor, while the command is still logged as override

1.4 latest git, as usual

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=403001&aid=3081638&group_id=31654