[srvx-bugs] [ srvx-Bugs-2964782 ] srvx shouldn't set APASS/UPASS

[SourceForge.net <no...@so...>]

Bugs item #2964782, was opened at 2010-03-06 19:05
Message generated for change (Tracker Item Submitted) made by zerofighte
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=403001&aid=2964782&group_id=31654

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: ircu protocol
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: ZeRoFiGhter (zerofighte)
Assigned to: Entrope (entrope)
Summary: srvx shouldn't set APASS/UPASS

Initial Comment:
Hi,

imho srvx shouldn't allow users to set APASS/UPASS or it should at least be configurable. We disabled those in the ircd, but using srvx they still could be set causing some strange effects.
suggested change (line offsets are possible again):

Index: src/proto-p10.c
===================================================================
--- src/proto-p10.c     (Revision 306)
+++ src/proto-p10.c     (Revision 307)
@@ -2562,6 +2562,8 @@
             }
             break;
         case 'U':
+            if (!(flags & MCP_FROM_SERVER))
+                goto error;
             if (add)
             {
                 if ((in_arg >= argc)
@@ -2578,6 +2580,8 @@
             }
             break;
         case 'A':
+            if (!(flags & MCP_FROM_SERVER))
+                goto error;
             if (add) {
                 if ((in_arg >= argc)
                     || keyncpy(change->new_apass, modes[in_arg++], sizeof(change->new_apass)))

version: srvx1.4 latest git

regards

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=403001&aid=2964782&group_id=31654