[srvx-bugs] [ srvx-Bugs-2946094 ] req on join problems

[SourceForge.net <no...@so...>]

Bugs item #2946094, was opened at 2010-02-04 20:09
Message generated for change (Tracker Item Submitted) made by zerofighte
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=403001&aid=2946094&group_id=31654

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: HelpServ
Group: 1.4
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: ZeRoFiGhter (zerofighte)
Assigned to: Adrian Dewhurst (sailorfrag)
Summary: req on join problems

Initial Comment:
hi,

well, i have no idea what to write ... as the issue appears for us while having a patch that highly influences this stuff ...

anyway: mod-helpserv.c line 4027 (at your current git head) has a typo. The variable to use as array index is 'j', not 'i'.

===
             if ((reqlist = dict_find(helpserv_reqs_bynick_dict, user->nick, NULL))) {
                 for (j=0; j < reqlist->used; j++)
-                    if (reqlist->list[i]->hs == hs)
+                    if (reqlist->list[j]->hs == hs)
                         break;
                 if (j < reqlist->used)
                     continue;
===

I'm not sure if it has any influence for your code ... combined with our patch set it has, but it's the req_join_check that does not really loop through the list because of this.

regards

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=403001&aid=2946094&group_id=31654