[srvx-bugs] [ srvx-Bugs-2787760 ] Wrong Key Handling

[SourceForge.net <no...@so...>]

Bugs item #2787760, was opened at 2009-05-06 11:50
Message generated for change (Tracker Item Submitted) made by dvdhrm
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=403001&aid=2787760&group_id=31654

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: David Herrmann (dvdhrm)
Assigned to: Nobody/Anonymous (nobody)
Summary: Wrong Key Handling

Initial Comment:
A recent GIT commit fixed a key handling bug:
http://srvx.git.sourceforge.net/git/gitweb.cgi?p=srvx;a=blobdiff;f=src/proto-p10.c;h=681231e81ee57cfcfd3a10eead95c024f7e230be;hp=8174a6919386e61a37fc0d6f1c8b5cf8247f180d;hb=9f489ed802628c45ed7db3cb763b452b110c1aa1;hpb=234eb10bbb6126de89ca8750689c8bfaf0f75da2

However, the apass fix uses the "upass" variables instead of the "apass" variables. Therefore the commit above makes it impossible to save
apass'es in the srvx. This should be fixed. I simply copy the wrong part of the commit now, it should be easy
to fix that typo:

@@ -2364,10 +2384,10 @@ mod_chanmode_parse(struct chanNode *channel, char **modes, unsigned int argc, un
             break;
         case 'A':
             if (add) {
-                if (in_arg >= argc)
+                if ((in_arg >= argc)
+                    || keyncpy(change->new_upass, modes[in_arg++], sizeof(change->new_upass)))
                     goto error;
                 change->modes_set |= MODE_APASS;
-                safestrncpy(change->new_apass, modes[in_arg++], sizeof(change->new_apass));
             } else {
                 change->modes_clear |= MODE_APASS;
                 if (!(flags & MCP_APASS_FREE)) {


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=403001&aid=2787760&group_id=31654