Re: [Srtp-development] Access to field 'type' results in a dereference of a null pointer in cipher.c

[Gaurav <gau...@gm...>]

There isn't an exact code path that exposes a null pointer dereference as
of now.
This was only from a good defensive coding viewpoint.


On Tue, Jun 10, 2014 at 6:17 PM, John Foley <fo...@ci...> wrote:

>  Thanks for the suggestion.  This is good defensive coding.  However,
> cipher_encrypt isn't part of the public API.  Have you identified a code
> path that exposes a null pointer dereference?  We've run Coverity on the
> code and I don't recall this being raised as an issue.
>
>
>
> On 06/10/2014 02:42 AM, Gaurav wrote:
>
>  Hi,
>
>  I'd like to file a bug reported by the clang static analyzer.
>
>  Description: Access to field 'type' results in a dereference of a null
> pointer (loaded from variable 'c')
> File: cipher/cipher.c
> Line: 395
>
>  I think macro 'cipher_encrypt' should check if the pointer 'c' exists.
> In case it doesn't exist it should return an appropriate error code such
> as 'err_status_no_such_op'.
>
>
>  I think macro 'cipher_encrypt' should expand to:
>
>  ((c) ? (((c)->type)->encrypt(((c)->state), (enc_buf), (&len))) :
> err_status_no_such_op)
>
>  instead of:
>
>  (((c)->type)->encrypt(((c)->state), (enc_buf), (&len)))
>
>
>  -Gaurav Nangla
>
>
> ------------------------------------------------------------------------------
> HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
> Find What Matters Most in Your Big Data with HPCC Systems
> Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
> Leverages Graph Analysis for Fast Processing & Easy Data Explorationhttp://p.sf.net/sfu/hpccsystems
>
>
>
> _______________________________________________
> Srtp-development mailing lis...@li...https://lists.sourceforge.net/lists/listinfo/srtp-development
>
>
>
>
> ------------------------------------------------------------------------------
> HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
> Find What Matters Most in Your Big Data with HPCC Systems
> Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
> Leverages Graph Analysis for Fast Processing & Easy Data Exploration
> http://p.sf.net/sfu/hpccsystems
> _______________________________________________
> Srtp-development mailing list
> Srt...@li...
> https://lists.sourceforge.net/lists/listinfo/srtp-development
>
>