Re: [Srcpd-devel] srcpd-2.1.4 build issues

[Guido S. <gui...@gm...>]

Am Wed, 03. Jun 2020 um 06:30:07 +0600 schrieb Denis Fateyev:

> Hello Guido,

Hi Denis,

> OK, I have patched the configure script in terms that it disables "ddl-s88"
> support conditionally on-the-fly.
> It doesn't fit for general use — just allows me to build the sources under
> various architectures without modifying configure options.
> For general use, it's better to disable "ddl-s88" with configure features —
> like you mentioned in the man-file.
> 
> 
> > I just have solved this "extern" variable declaration issues. Can you
> > check the svn repository if it fits for you?
> >
> 
> Looks good for now. I haven't spotted any new build errors.
> 
> 
> Now, there are some other suggestions:
> 
> 1) Under "ppc64le" arch:
> 
> -----
> gcc -D_REENTRANT -DSYSCONFDIR=\"/etc\" -DHAVE_CONFIG_H -I.
> -I/usr/include/libxml2   -O2 -g -pipe -Wall -Werror=format-security
> -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions
> -fstack-protector-strong -grecord-gcc-switches
> -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fcommon -m64 -mcpu=power8
> -mtune=power8 -fasynchronous-unwind-tables -fstack-clash-protection
> -pthread -c -o srcpd.o srcpd.c
> In file included from /usr/include/bits/termios.h:76,
>                  from /usr/include/termios.h:39,
>                  from config-srcpd.h:30,
>                  from srcp-command.c:12:
> srcp-time.h:16:16: error: expected '{' before numeric constant
>    16 | typedef struct _VTIME
>       |                ^~~~~~
> -----
> This typedef declaration conflicts with another global struct which is
> already defined.
> Build log example:
> https://kojipkgs.fedoraproject.org//work/tasks/530/45330530/build.log
> 
> I have changed the declaration this way to avoid conflicts:
> 
> --- a/src/srcp-time.h
> +++ b/src/srcp-time.h
> @@ -13,7 +13,7 @@
>  #include <sys/time.h>
> 
>  /* time value */
> -typedef struct _VTIME
> +typedef struct VTIMEDEF
>  {
>    int day;
>    int hour;
> 
> — and it went well under all architectures. You could consider renaming it,
> too.
> 
> 2) German man-files and readme files are presented in Latin1 encoding — not
> a real issue, but a little bit frustrating to read them in the modern
> Unicode console:
> -----
> .SH BESCHREIBUNG
> .PP
> Dieses Handbuch ist nicht vollst�ndig. F�r weitere Informationen
> besuchen Sie bitte die Internetseite des Projektes unter
> http://srcpd.sourceforge.net/.
> -----
> 
> You could consider recoding them to UTF8 as the most compatible option,
> e.g. using the following snippet:
> -----
> for file in ./man/de/srcpd.* ./DESIGN ./README; do
>   iconv -f latin1 -t utf8 < $file > $file.new
>   mv -f $file.new $file
> done
> -----
> 
> 3) https://sourceforge.net/p/srcpd/code/1754/
> 
> Die ioperm() Funktion selbst ist+typischerweise nur auf i386 Hardware verfügbar.
> 
> Nicht nur x86, sondern auch auf amd64 (x86_64) verfügbar.
> Alles in allem, wie es früher bemerkt wurde, die beste Lösung wäre den
> "ddl-s88" den anderen Architekturen anzupassen (wenn es möglich ist).

thanks for your input, changes are applied. Release 2.1.5 is out now.

  https://sourceforge.net/projects/srcpd/files/srcpd/2.1.5/


Guido

-- 
http://wie-im-flug.net/
http://www.lug-burghausen.org/