[SrcML] Method.java
Status: Beta
Brought to you by:
crashchaos
From: Frank R. <fra...@in...> - 2005-05-19 21:21:05
|
This is primarily for Dennis as he's working on the API convenience methods. I've just taken a quick look on the CVS commits and seen the following for de.srcml.dom.Method.setConstructor: else { Element e = new Type(); ! e.addAttribute(Type.ATTR_NAME, Type.TYPE_VOID); ! elements().add(0, e); } Please make sure your changes adhere to the DTD/Schema ! The return type of a method can not just be added as the last child. See srcml/srcml.xsd and especially Tmethod (lines 381ff) for that. It would be nice if you could add unit tests for these methods too (which should catch those errors, as the least thing to test for is adherence to the Schema after the changes.) I think I will import the unittests module for this into CVS tomorrow. -- Raiser, Frank Student @ University of Ulm (www.uni-ulm.de) I think it is inevitable that people program poorly. Training will not substantially help matters. We have to learn to live with it. (Alan Perlis) |