#105 'custom_from' / multiple identities buglet

[Anonymous]

When one has multiple identities, and replies to a
message addressed to one of those identities, the
"From:" line correctly defaults to the appropriate
identity (i.e. the alias to whom the original message
was addressed).

However, if one is also using the custom_from plugin,
the 'custom from' value still shows its standard
default. This is at best confusing, and at worse will
send the message with the 'stock' custom_from name,
rather than the selected identity.

I have patched around this several times, and would
really like to see it included in the plugin. Here's a
quick snippet showing the change (at the top of
compose, where it is listing the multiple identites for
the From: line):

for ($i = 1; $i < $idents; $i ++)
{
$fn = getPref($data_dir, $username,
'full_name' . $i);
$em = getPref($data_dir, $username,
'email_address' . $i);

echo '<option value="' . $i . '"';
if (isset($identity) && $identity == $i)
{
echo ' selected';
+
+ global $custom_from;
+ $custom_from = htmlspecialchars($fn);
+
+ if ($em != "")
+ {
+ $custom_from .= htmlspecialchars(' <' .
$em . '>');
+ }
}

echo '>' . htmlspecialchars($fn);

Comments to: sqbugsxyz.5.wcdw / at / spameater / dot / org

[Thijs Kinkhorst]

Logged In: YES
user_id=285765

Specific to custom_from plugin.