Menu

#490 Don't store username / password in session cookie

None
closed-fixed
None
5
2022-05-23
2014-03-28
naptastic
No

Please find attached a patch to the login_auth plugin that gets username and password from the environment, rather than storing them in a session cookie. This can prevent some information disclosure exploits.

1 Attachments

Discussion

  • Paul Lesniewski

    Paul Lesniewski - 2022-05-23
    • status: open --> closed-fixed
    • assigned_to: Paul Lesniewski
    • Group: -->
     
  • Paul Lesniewski

    Paul Lesniewski - 2022-05-23

    Thanks for your contribution and I'm sorry that notification didn't go out when you submitted this so it could be addressed right away.

    Your patch doesn't put anything into the environment which also gets reset with every page request, so I have to assume that your external authentication mechanism populates the username and password into the PHP environment automatically. That isn't something we can hard code because it's specific to your implementation -- but what I did do was provide configuration settings that allow the administrator to say the credentials should not be stored in the session data and should be thus retrieved from their external source for every page request.

    Thanks again for your suggestion.

     

Log in to post a comment.