Nice patch. Works okay in firefox and Internet Explorer, but it
looks like... er... crap in Opera (no offense). Text has some
serious indentation issues, all folders have the list item
characters (*) on them, javascript doesn't appear to apply/work
at all. I don't have any other browsers handy right now so I
cannot test. I might consider using something similar to this
when extracting the left frame code into templates.
Good work.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Are you sure opera got the updated css-file, and its not
using the old one from cache? Both the javascript and the
css works fully here with opera 8.51 on linux. I tested it
on opera 8.50 before i sent it to this list and it was
working very good then.
The javascript has been tested to be working in these browsers:
Internet Explorer 5.5 for Windows, Internet Explorer 6 for
Windows, Internet Explorer 5.2 for Macintosh, Firefox 1.0,
Mozilla 1.7.3, Opera 7.54, Opera 8.51, Safari 1.2.4, and
Konqueror 3.1.4.
The css is simple and should work in any browser with near
ok css support.
I'm aware of the fact that it wont save the collapsed state,
but i'm sure that could be fixed without much trouble.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
It was yes, fonts had changed size, and other adjustments
had made just fine. However doing a simple css test using
simple list items showed Opera should work fine, for some
reason mine was misbehaving. I'm reinstalling it shortly
anyway as I'm on a cleaning spree, and I shall retest then.
The only reservation I have is the fact that we're working
towards templating, and this'd be much more worth
implementing, rather than changing the html code.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
javascript for expanding/collapsing
css
left_main.php.diff
Logged In: YES
user_id=620333
Nice patch. Works okay in firefox and Internet Explorer, but it
looks like... er... crap in Opera (no offense). Text has some
serious indentation issues, all folders have the list item
characters (*) on them, javascript doesn't appear to apply/work
at all. I don't have any other browsers handy right now so I
cannot test. I might consider using something similar to this
when extracting the left frame code into templates.
Good work.
Logged In: YES
user_id=620333
Forgot to mention that while the JS collapsing folders is good,
it doesn't take into account the saving of the collapsed state.
Logged In: YES
user_id=795516
Are you sure opera got the updated css-file, and its not
using the old one from cache? Both the javascript and the
css works fully here with opera 8.51 on linux. I tested it
on opera 8.50 before i sent it to this list and it was
working very good then.
The javascript has been tested to be working in these browsers:
Internet Explorer 5.5 for Windows, Internet Explorer 6 for
Windows, Internet Explorer 5.2 for Macintosh, Firefox 1.0,
Mozilla 1.7.3, Opera 7.54, Opera 8.51, Safari 1.2.4, and
Konqueror 3.1.4.
The css is simple and should work in any browser with near
ok css support.
I'm aware of the fact that it wont save the collapsed state,
but i'm sure that could be fixed without much trouble.
Logged In: YES
user_id=620333
It was yes, fonts had changed size, and other adjustments
had made just fine. However doing a simple css test using
simple list items showed Opera should work fine, for some
reason mine was misbehaving. I'm reinstalling it shortly
anyway as I'm on a cleaning spree, and I shall retest then.
The only reservation I have is the fact that we're working
towards templating, and this'd be much more worth
implementing, rather than changing the html code.