From: Chris L. <lo...@pa...> - 2005-09-25 08:43:34
|
Hi, I hope this is the right list to ask about a reproducible problem. If I should have sent this to the development list, I will be happy to repost appropriately. I would like to report a problem with SM's "Compose in New Window" option when a custom window size is chosen. The undesired behavior is that the custom window size is sometimes ignored. The cause is that the appropriate javascript is missing in "right_main.php" first shown upon login, but is finally provided in right_main.php after going to the options page and clicking submit. This is a SM installation at my ISP; I do not see any version information, but will be happy to report what I find if you tell me where to look. Here's the code that should (and eventually does) appear in right_main.php for the compose link; note that I have a custom window size entered: <a href="javascript:void(0)" onclick="comp_in_new('/src/compose.php?mailbox=INBOX&startMessage=1')">Compose</a> Here's the code that actually appears in right_main.php when I first login: <a href="/src/compose.php?mailbox=INBOX&startMessage=1" target="_blank">Compose</a> The default code (no custom window size) causes a huge window to open. This is a small issue, but pretty annoying to me, and probably can be fixed very easily. This is easy for me to reproduce, but because I cannot provide version info, it might not be easy for someone else :-( Basically I choose the "compose in new window" option and set a size for the compose window, logout, log back in, and click on the "Compose" link. I use Firefox 1.0.6 if that matters. Please advise, thanks for listening. chris... |
From: Jonathan A. <jo...@sq...> - 2005-09-26 14:04:49
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello Chris Lott, On Sunday, September 25, 2005, you wrote: > Hi, > I hope this is the right list to ask about a reproducible problem. > If I should have sent this to the development list, I will be happy > to repost appropriately. This list is just fine :) > I would like to report a problem with SM's "Compose in New Window" > option when a custom window size is chosen. Funnily enough, this came up on IRC just last week. The observation on the issue is that after changing the size of the compose window options, you MUST press the "refresh page" link that appears. > The undesired behavior is that the custom window size is sometimes > ignored. The cause is that the appropriate javascript is missing in > "right_main.php" first shown upon login, but is finally provided in > right_main.php after going to the options page and clicking submit. > This is a SM installation at my ISP; I do not see any version > information, but will be happy to report what I find if you tell me > where to look. > Here's the code that should (and eventually does) appear in right_main.php > for the compose link; note that I have a custom window size entered: > <a href=3D"javascript:void(0)" > onclick=3D"comp_in_new('/src/compose.php?mailbox=3DINBOX&startMessage= =3D1')">Compose</a> comp_in_new is a javascript function. If you look at the rest of the source code on that page, you should see where it is setting the size and what not. > Here's the code that actually appears in right_main.php when I first logi= n: > <a href=3D"/src/compose.php?mailbox=3DINBOX&startMessage=3D1" target=3D"_blank">>Compose</a> > The default code (no custom window size) causes a huge window to open. > This is a small issue, but pretty annoying to me, and probably can be > fixed very easily. Unfortunately I don't believe you can size a window that isn't launched by Javascript. The last URL is not launched by javascript. This suggests that somewhere along the way, we don't properly detect the javascript. > I use Firefox 1.0.6 if that matters. Of course, knowing as much as we can always helps. Login to SquirrelMail, go to Options, Display Preferences. Change the "Javascript" option to "Always". Logout, and log back in again. Check the "Compose" link and make sure it /is/ a javascript URL. Then go to options, display preferences, and change the window size for the compose window. Once changed, and you hit save, make sure you hit the "Refresh page" link (not sure if you can get away with just refreshing the window or not, so try the link to start). Then test to see if the compose window has resized. - -- Jonathan Angliss <jo...@sq...> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (MingW32) iD8DBQFDN//xK4PoFPj9H3MRAtWdAJwJ8Yf9X7J1RQqe9GvP5m6jKs2+mwCglfi+ du9/lewVSBcq/CajBYROvKc=3D =3D6lO8 -----END PGP SIGNATURE----- |
From: Chris L. <lo...@pa...> - 2005-09-26 14:54:44
|
On Mon, September 26, 2005 10:04, Jonathan Angliss wrote: > .. > Unfortunately I don't believe you can size a window that isn't > launched by Javascript. The last URL is not launched by javascript. > This suggests that somewhere along the way, we don't properly detect > the javascript. Thanks for the note. Right, I think a browser will only set the size of a newly opened window if it's done via a javascript link. > Of course, knowing as much as we can always helps. Login to > SquirrelMail, go to Options, Display Preferences. Change the > "Javascript" option to "Always". Logout, and log back in again. Did that, and the compose window opened with the expected size on the first try after login. That's what I want. In other words, when I forced use of javascript, it works as expected. As you wrote (above), something about javascript detection might not be working properly; in my case, at first login. May I suggest putting this in some FAQ along with the "use custom compose window size" discussion? Thanks again. chris... p.s. How do I suggest adding a "send & close" button to the standalone compose window? Log a new feature request? |
From: Jonathan A. <jo...@sq...> - 2005-09-27 01:37:52
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello Chris Lott, On Monday, September 26, 2005, you wrote: >> Unfortunately I don't believe you can size a window that isn't >> launched by Javascript. The last URL is not launched by javascript. >> This suggests that somewhere along the way, we don't properly >> detect the javascript. > Thanks for the note. Right, I think a browser will only set the size > of a newly opened window if it's done via a javascript link. >> Of course, knowing as much as we can always helps. Login to >> SquirrelMail, go to Options, Display Preferences. Change the >> "Javascript" option to "Always". Logout, and log back in again. > Did that, and the compose window opened with the expected size on the > first try after login. That's what I want. In other words, when I forced > use of javascript, it works as expected. As you wrote (above), something > about javascript detection might not be working properly; in my case, at > first login. The question then should be "why did javascript detection fail"? I don't think you included your SquirrelMail version information in your first email, so that'd be a start. I vaguely remember seeing a bug report (and fix) in a fairly recent version that involved the "javascript auto-detect" stuff, and how it was being "unset" when you changed certain options, so you might want to test against the latest release, or latest stable cvs snapshot. > May I suggest putting this in some FAQ along with the "use custom compose > window size" discussion? Thanks again. > chris... > p.s. How do I suggest adding a "send & close" button to the standalone > compose window? Log a new feature request? A feature request would work, that way it doesn't get lost in the maze of posts here :) - -- Jonathan Angliss <jo...@sq...> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (MingW32) iD8DBQFDOKJnK4PoFPj9H3MRAqsyAJ9FpaWxW8EC7wEMi4w4y0Bv8UxJFACg0q3c mTb9CVlHvHELvHHQAbaAab8= =eta5 -----END PGP SIGNATURE----- |
From: Chris L. <lo...@pa...> - 2005-09-27 09:26:25
|
On Mon, September 26, 2005 21:37, Jonathan Angliss wrote: > The question then should be "why did javascript detection fail"? I > don't think you included your SquirrelMail version information in your > first email, so that'd be a start. I vaguely remember seeing a bug > report (and fix) in a fairly recent version that involved the > "javascript auto-detect" stuff, and how it was being "unset" when you > changed certain options, so you might want to test against the latest > release, or latest stable cvs snapshot. No I did not include that info. I'm using an installation of SM maintained by my isp (pair.com) and I simply don't know where to find the version info. I'm also not able to install and try the latest release. > A feature request would work, that way it doesn't get lost in the maze > of posts here :) Ok. Is that the tracker maintained by source forge, just like the bug tracker? chris... |
From: Tomas K. <to...@us...> - 2005-09-27 09:59:54
|
> On Mon, September 26, 2005 21:37, Jonathan Angliss wrote: >> The question then should be "why did javascript detection fail"? I >> don't think you included your SquirrelMail version information in your >> first email, so that'd be a start. I vaguely remember seeing a bug >> report (and fix) in a fairly recent version that involved the >> "javascript auto-detect" stuff, and how it was being "unset" when you >> changed certain options, so you might want to test against the latest >> release, or latest stable cvs snapshot. > > No I did not include that info. I'm using an installation of SM > maintained by my isp (pair.com) and I simply don't know where to find the > version info. I'm also not able to install and try the latest release. check your email headers. SquirrelMail adds version information by default. User-Agent: SquirrelMail/1.4.5 >> A feature request would work, that way it doesn't get lost in the maze >> of posts here :) > > Ok. Is that the tracker maintained by source forge, just like the bug > tracker? http://sourceforge.net/tracker/?group_id=311 |