From: Walt M. <wma...@gm...> - 2005-03-04 06:48:46
|
I had the sharedtodolists v1.4 working with the previous shared_calendars v1.1.1, but it dies after upgrading to calendar_file_backend v1.0 and shared_calendars v2.0.1. ToDo Administration works ok. I get the following error when referencing: http://<domain>/mail/plugins/todo/todo_check.php Fatal error: Cannot redeclare delete_event() (previously declared in /home/ihador/public_html/mail/plugins/todo/todo_data.php:135) in /home/ihador/public_html/mail/plugins/calendar/backend_functions.php on line 404 Looks like they both declare function delete_event(). Is this a known incompatibility? Any workarounds? Thanks, Walt |
From: Walt M. <wma...@gm...> - 2005-03-04 15:59:10
|
I actually found a total of 5 function naming conflicts. I fixed these in the shared todo plugin by changing all the conflicting function names and their references. Seems to work ok now. - Walt On Thu, 3 Mar 2005 22:48:23 -0800, Walt Mayberry <wma...@gm...> wrote: > I had the sharedtodolists v1.4 working with the previous > shared_calendars v1.1.1, but it dies after upgrading to > calendar_file_backend v1.0 and shared_calendars v2.0.1. > > ToDo Administration works ok. I get the following error when referencing: > http://<domain>/mail/plugins/todo/todo_check.php > > Fatal error: Cannot redeclare delete_event() (previously declared in > /home/ihador/public_html/mail/plugins/todo/todo_data.php:135) in > /home/ihador/public_html/mail/plugins/calendar/backend_functions.php > on line 404 > > Looks like they both declare function delete_event(). > > Is this a known incompatibility? Any workarounds? > > Thanks, > Walt > |
From: p d. t. <pdo...@an...> - 2005-03-04 19:34:13
|
Walt Mayberry wrote: > I had the sharedtodolists v1.4 working with the previous > shared_calendars v1.1.1, but it dies after upgrading to > calendar_file_backend v1.0 and shared_calendars v2.0.1. > > ToDo Administration works ok. I get the following error when referencing: > http://<domain>/mail/plugins/todo/todo_check.php > > Fatal error: Cannot redeclare delete_event() (previously declared in > /home/ihador/public_html/mail/plugins/todo/todo_data.php:135) in > /home/ihador/public_html/mail/plugins/calendar/backend_functions.php > on line 404 > > Looks like they both declare function delete_event(). > > Is this a known incompatibility? Any workarounds? Not known until now. :) Workaround is to change the name of one or the other. I am partial to not changing the calendar plugin, since it will supercede the TODO plugin anyway (task lists will be a future enhancement to the calendar; if there's anything specific you like about that plugin that should be integrated with the calendar plugin, please let us know). I assume you know enough to go change it yourself? - paul |
From: Walt M. <wma...@gm...> - 2005-03-04 20:40:01
|
I made the necessary changes to the todo plugin. Just prepended "td_" to conflicting function names and all calls to them. I have done basic testing and all now seems to work with no conflict. Four files were effected. I'd be happy to share these with anyone interested. On Fri, 04 Mar 2005 11:33:55 -0800, p dont think <pdo...@an...> wrote: > Not known until now. :) Workaround is to change the name of one or the > other. I am partial to not changing the calendar plugin, since it will > supercede the TODO plugin anyway (task lists will be a future > enhancement to the calendar; if there's anything specific you like about > that plugin that should be integrated with the calendar plugin, please > let us know). > > I assume you know enough to go change it yourself? > > - paul > |
From: Fredrik J. <sqm...@fi...> - 2005-03-04 22:00:49
|
>> Not known until now. :) Workaround is to change the name of one or >> the other. I am partial to not changing the calendar plugin, since it >> will supercede the TODO plugin anyway (task lists will be a future >> enhancement to the calendar; if there's anything specific you like >> about that plugin that should be integrated with the calendar plugin, >> please let us know). >> >> I assume you know enough to go change it yourself? > > > I made the necessary changes to the todo plugin. Just prepended "td_" > to conflicting function names and all calls to them. I have done basic > testing and all now seems to work with no conflict. Four files were > effected. I'd be happy to share these with anyone interested. Hi Walt. Please send a unified diff to this list and to the plugin maintainer. Sincerely, Fredrik. |
From: Bob H. <hut...@mi...> - 2005-03-07 14:09:55
Attachments:
todo_plugin.diff
|
On Friday 04 Mar 2005 21:59, Fredrik Jervfors wrote: > >> Not known until now. :) Workaround is to change the name of one or > >> the other. I am partial to not changing the calendar plugin, since it > >> will supercede the TODO plugin anyway (task lists will be a future > >> enhancement to the calendar; if there's anything specific you like > >> about that plugin that should be integrated with the calendar plugin, > >> please let us know). > >> > >> I assume you know enough to go change it yourself? > > > > I made the necessary changes to the todo plugin. Just prepended "td_" > > to conflicting function names and all calls to them. I have done basic > > testing and all now seems to work with no conflict. Four files were > > effected. I'd be happy to share these with anyone interested. > > Hi Walt. > > Please send a unified diff to this list and to the plugin maintainer. I have attached a diff that applies the 'td_' changes as suggested by Walt Mayberry. I have also done some 'E_ALL' cleanup, and fixed some sorting bugs for 'usort' put the diff file into 'plugins' and run patch -p0 < todo_plugin.diff This has also been CC'd to bja...@sa... whose email address I found in the INSTALL file The plugin could also do with a 'version' file..... HTH -- ----------------- Bob Hutchinson Midwales dot com ----------------- |
From: Erich G. <er...@gr...> - 2005-03-05 12:00:15
|
Walt, would you please give more detailed informations about these function naming conflicts you fixed? Erich > I actually found a total of 5 function naming conflicts. I fixed > these in the shared todo plugin by changing all the conflicting > function names and their references. Seems to work ok now. - Walt > > > On Thu, 3 Mar 2005 22:48:23 -0800, Walt Mayberry <wma...@gm...> > wrote: >> I had the sharedtodolists v1.4 working with the previous >> shared_calendars v1.1.1, but it dies after upgrading to >> calendar_file_backend v1.0 and shared_calendars v2.0.1. >> >> Walt >> |
From: Walt M. <wma...@gm...> - 2005-03-05 17:51:59
|
The conflicting function names in sharedtodolists.1.4 were: delete_event() select_option_year() select_option_month() select_option_day() select_option_priority() To fix the problem, I prepended "td_" to each function declaration and reference in the four files: event_create.php event_edit.php functions.php todo_data.php I casually tested this by running through the basic functions of todo. I did not do extensive testing, so there may be other conflicts yet to popup. I will be rolling this out to about 15 users over the next few weeks, so it will get further exercise. I just edited these files in the DW code editor. I'm not clear on how to create a unified diff and don't have the tools set up for this. I can send you a zip of the 4 files or just id line numbers within files that required change. Walt On Sat, 5 Mar 2005 12:59:58 +0100 (CET), Erich Graller <er...@gr...> wrote: > Walt, > > would you please give more detailed informations about > these function naming conflicts you fixed? > > Erich > > > I actually found a total of 5 function naming conflicts. I fixed > > these in the shared todo plugin by changing all the conflicting > > function names and their references. Seems to work ok now. - Walt > > > > > > On Thu, 3 Mar 2005 22:48:23 -0800, Walt Mayberry <wma...@gm...> > > wrote: > >> I had the sharedtodolists v1.4 working with the previous > >> shared_calendars v1.1.1, but it dies after upgrading to > >> calendar_file_backend v1.0 and shared_calendars v2.0.1. > >> > >> Walt > >> |