squirrelmail-imapproxy

Re: [SM-imapproxy] imapproxy Patches

[Richard L. <rl...@wi...>]

Moving to the imapproxy list.

I've been running with these patches in production for a couple days now
with no complaints.

However, my production system is not on OpenSSL 1.1, so that patch
hasn't gotten run-time testing, only compile-time.

I've also attached the patches, so you're not dependent on my github
repository.

On 11/23/2016 06:04 PM, Richard Laager wrote:
> I see you have recently accepted a round of imapproxy patches. I would
> like to bring the following patches to your attention.
> 
> So far, these have only passed the "it compiles" test. I'll be testing
> all this code in production in a few days (after the Thanksgiving holiday).
> 
> The EGD conditional is backwards:
> https://github.com/rlaager/imapproxy-pkg/blob/master/debian/patches/fix-egd-ifdef.patch
> 
> This fixes a compiler warning about not checking the return value from
> dup():
> https://github.com/rlaager/imapproxy-pkg/blob/master/debian/patches/check-dup-return-value.patch
> 
> This fixes some missing function definitions:
> https://github.com/rlaager/imapproxy-pkg/blob/master/debian/patches/fix-missing-definitions.patch
> 
> This fixes some warnings about size_t printf formatters. Note, I'm not
> sure how portable the "z" modifer is:
> https://github.com/rlaager/imapproxy-pkg/blob/master/debian/patches/fix-size_t-formatters.patch
> 
> This uses socklen_t instead of int to fix some type mismatch warnings:
> https://github.com/rlaager/imapproxy-pkg/blob/master/debian/patches/fix-socklen_t-types.patch
> 
> This fixes signedness warnings:
> https://github.com/rlaager/imapproxy-pkg/blob/master/debian/patches/fix-ssl-types.patch
> 
> This fixes compiling on OpenSSL 1.1:
> https://github.com/rlaager/imapproxy-pkg/blob/master/debian/patches/openssl-1.1.patch
> 
> Are these variables used? If not, they should be removed rather than
> #ifdef 0'ed as this patch does:
> https://github.com/rlaager/imapproxy-pkg/blob/master/debian/patches/remove-unused-variables.patch

-- 
Richard

Re: [SM-imapproxy] imapproxy Patches

[Richard L. <rl...@wi...>]

I've attached another patch. This one fixes a spelling error.

-- 
Richard

Re: [SM-imapproxy] imapproxy Patches

[Richard L. <rl...@wi...>]

Here's one more patch. This is pretty minor stylistic stuff in
imapproxy.conf that you may or may not agree with.

-- 
Richard

Re: [SM-imapproxy] imapproxy Patches

[Paul L. <pa...@sq...>]

On Sat, December 10, 2016 12:49 pm, Richard Laager wrote:
> Here's one more patch. This is pretty minor stylistic stuff in
> imapproxy.conf that you may or may not agree with.

Hi Richard, thanks for all the patches.  I will be reviewing them as soon
as I can make time.  I have applied this one (the last (stylistic) one)
just now so you know these are being seen and appreciated!