I would like to bring to your attention a internationalization issue with CVS
Starting conf.pl and selecting "5. Templates->1. Change Template set", I can
detect all available template sets (out of the box it is only "Default
template"). Leaving conf.pl, a couple of new lines were generated in
$aTemplateSet['NAME'] = 'Default template';
If user has decided not to use the very common English language (for whatever
reason...) in users display options, only 'Default template' pops up...
This is a breach of the internationalization approach.
I would propose either to store the string as "_('Default template')" in
config.php (by conf.pl), which is the quickest solution
To refer to an config.php file (in "templates/default") which sets up the proper
description (using the _() approach).
Second solution has the benefit that if admin creates a new template set, he
will stumble immediately over the necessity to take care about
internationalization (if he/she want to do so).
Removing the "templateset" lines from config.php ends up with a user display
option field set to empty and is from point of view not convenient for the
end-users digging around with their user options.
Live long and prosper