From: Eric D. <ec...@ec...> - 2003-09-15 11:39:49
|
I don't see a final source-based solution for this in the problem-FAQ. I fixed this in a crude way by insuring that "SQMSESSID=" . session_id() or the equivalent was appended to every callback, e.g. every Location: header and every action=blah.php, to all applicable files in the 'src' directory. If my recoding is needless, still it points the way to locate "the bug", if this problem is due to a bug and not the vagaries of the php.ini file settings. In particular my setting autostart to 1 in php.ini broke other generic PHP code in my installation so that is (and other gratuitous fiddling with the php.ini file is) not a good solution. See my comments in the "LoginError" section of the Problems FAQ. I can tar up my hacked version for review - my hacks force use of PHP 4.1 or better, see the remarks. -ecsd |
From: Jonathan A. <jo...@sq...> - 2003-09-15 13:51:10
|
Hello Eric, On Monday, September 15, 2003, Eric Dynamic wrote... > I don't see a final source-based solution for this in the problem-FAQ. > I fixed this in a crude way by insuring that "SQMSESSID=" . session_id() > or the equivalent was appended to every callback, e.g. every Location: header > and every action=blah.php, to all applicable files in the 'src' directory. This almost looks like you have cookies disabled as it cannot set the session details to the cookie. Or you have the session.use_cookie set to 0 and the session.use_trans_sid also set to 0. > If my recoding is needless, still it points the way to locate "the bug", > if this problem is due to a bug and not the vagaries of the php.ini file > settings. It will be needless soon. The changes you're making are already on the books of my work (about 90% done) so that we can have cookieless sessions. -- Jonathan Angliss (jo...@sq...) |
From: Daniel W <dan...@li...> - 2003-10-02 10:20:15
|
> > It will be needless soon. The changes you're making are already on the > books of my work (about 90% done) so that we can have cookieless > sessions. > Fantastic - then hopefully it'll start working with Netscape 4.x etc. |
From: Daniel W <dan...@li...> - 2003-11-27 00:10:22
|
Trivial change request: Would it be possible to have the DATE column in the main message list to be left aligned? At the moment it is center and is very messy looking. Objections? Daniel |
From: Chris H. <ta...@sq...> - 2003-11-27 19:38:33
|
> Would it be possible to have the DATE column in the main message list t= o > be > left aligned? At the moment it is center and is very messy looking. Looks fine to me. Maybe you could post a screenshot of your installation= ? --=20 Chris Hilts ta...@sq... |
From: <pdo...@an...> - 2003-11-27 22:11:23
|
>> Would it be possible to have the DATE column in the main message list = to >> be >> left aligned? At the moment it is center and is very messy looking. > > Looks fine to me. Maybe you could post a screenshot of your installati= on? He is right, it is centered, however, I don't think it's messy at all - I think he is overstating it to make his point. I seem to remember a threa= d about this before, and someone had a reason why it should just stay as is= . It's *such* a small nit to pick.... If you want to hack it yourself, Daniel, here is the patch (line numbers may be slightly off due to message flags plugin): --- functions/mailbox_display.phporig Thu Nov 27 14:02:28 2003 +++ functions/mailbox_display.php Thu Nov 27 14:02:55 2003 @@ -208,7 +208,7 @@ echo html_tag( 'td', $bold . $flag . $fontstr . $date_string . $fontstr_end . $flag_end . $bold_end, - 'center', + 'left', $hlt_color, 'nowrap' ); break; |
From: Daniel W. <dan...@li...> - 2003-11-27 22:26:37
|
A small nit perhaps but one which only needs the smallest of tweezers to put right. =) I'd be interested to hear the argument for centered as I really can't think of any reason for it not to be left aligned. If, say, you are scanning down a long list for a particular dated email it's a lot easier to do if everything is lined up. Best regards, Daniel ----- Original Message ----- From: <pdo...@an...> To: <ta...@sq...>; <dan...@li...> Cc: <squ...@li...> Sent: Thursday, November 27, 2003 10:05 PM Subject: Re: [SM-DEVEL] Date Alignment >> Would it be possible to have the DATE column in the main message list to >> be >> left aligned? At the moment it is center and is very messy looking. > > Looks fine to me. Maybe you could post a screenshot of your installation? He is right, it is centered, however, I don't think it's messy at all - I think he is overstating it to make his point. I seem to remember a thread about this before, and someone had a reason why it should just stay as is. It's *such* a small nit to pick.... If you want to hack it yourself, Daniel, here is the patch (line numbers may be slightly off due to message flags plugin): --- functions/mailbox_display.phporig Thu Nov 27 14:02:28 2003 +++ functions/mailbox_display.php Thu Nov 27 14:02:55 2003 @@ -208,7 +208,7 @@ echo html_tag( 'td', $bold . $flag . $fontstr . $date_string . $fontstr_end . $flag_end . $bold_end, - 'center', + 'left', $hlt_color, 'nowrap' ); break; |
From: Chris W. <ch...@ti...> - 2003-12-02 21:38:15
|
I know it's nit picking, and I was probably the one that brought this up last time.. we chose to do align=right for the date field after considering all of the visual elements.. but in any case, I think align=center is the least desirable of alignments when you have a screen resolution of 800x600 or less. In any case, consistency is a good thing, and SM gets enough criticism for the simplicity of the interface which lacks some of the "gloss" of a usually bloated "full featured" IMAP client.. but this simplicity is why I use SM as my primary reader! =) If it gets changed in CVS, that's one less "tweak" I have to do to upgrade SM here, and I do think it looks a little better. -- Chris Winterrowd Unix E-mail Administrator Texas Instruments Inc. ch...@ti... > A small nit perhaps but one which only needs the smallest of tweezers > to put right. =) > > I'd be interested to hear the argument for centered as I really can't > think of any reason for it not to be left aligned. > > If, say, you are scanning down a long list for a particular dated > email it's a lot easier to do if everything is lined up. > > Best regards, > Daniel > > ----- Original Message ----- > From: <pdo...@an...> > To: <ta...@sq...>; <dan...@li...> > Cc: <squ...@li...> > Sent: Thursday, November 27, 2003 10:05 PM > Subject: Re: [SM-DEVEL] Date Alignment > > >>> Would it be possible to have the DATE column in the main message >>> list to be left aligned? At the moment it is center and is very >>> messy looking. >> >> Looks fine to me. Maybe you could post a screenshot of your installation? > > He is right, it is centered, however, I don't think it's messy at all - I > think he is overstating it to make his point. I seem to remember a thread > about this before, and someone had a reason why it should just stay as is. > It's *such* a small nit to pick.... > > If you want to hack it yourself, Daniel, here is the patch (line numbers > may be slightly off due to message flags plugin): > > --- functions/mailbox_display.phporig Thu Nov 27 14:02:28 2003 > +++ functions/mailbox_display.php Thu Nov 27 14:02:55 2003 > @@ -208,7 +208,7 @@ > echo html_tag( 'td', > $bold . $flag . $fontstr . $date_string . > $fontstr_end . $flag_end . $bold_end, > - 'center', > + 'left', > $hlt_color, > 'nowrap' ); > break; > > > > > > > |
From: Daniel W. <dan...@li...> - 2003-12-02 22:38:09
|
I could be happy with align right yes - then all the times would line up. But <center > is just ridiculous. It's ugly. There is no sense in it at all. I don't like hacking sm code because then i have to do the same each upgrade I make. Generally the SM interface is great - but this little niggle is like the wife squeezing toothpaste from the wrong end. Although I don't have a wife so I can only guess at that. ;o) Daniel |
From: Brian G. P. <br...@br...> - 2003-12-03 02:26:08
|
Can anybody think of a good reason NOT to change to right alignment? I've only heard reasons TO make the change. If this is the case, then why waste any more time on it? Regards, - Brian |
From: Jonathan A. <jo...@sq...> - 2003-12-03 03:22:30
|
On Tue, 2003-12-02 at 20:26, Brian G. Peterson wrote: > Can anybody think of a good reason NOT to change to right alignment? > > I've only heard reasons TO make the change. If this is the case, then why > waste any more time on it? I don't see a problem with at least making it optional. Everybody has a preference, they all seem slightly varied on here... some want it centered, some left, some right... Shouldn't be difficult to just add a case statement in there, and a user preferences... probably a total of 20 lines of code at the most, and everybody is happy then. -- Jonathan Angliss (jo...@sq...) |
From: Simon W. <si...@ca...> - 2003-12-03 08:11:04
|
02-Dec-03 at 21:24, Jonathan Angliss (jo...@sq...) wrote : > On Tue, 2003-12-02 at 20:26, Brian G. Peterson wrote: > > Can anybody think of a good reason NOT to change to right alignment? > > > > I've only heard reasons TO make the change. If this is the case, then why > > waste any more time on it? > > I don't see a problem with at least making it optional. Everybody has a > preference, they all seem slightly varied on here... some want it > centered, some left, some right... Shouldn't be difficult to just add a > case statement in there, and a user preferences... probably a total of > 20 lines of code at the most, and everybody is happy then. IMHO, this kind of thing should entirely be handled in CSS. Each element should belong to a class, and those classes should have their styles. Then, switching CSS stylesheets could align whatever wherever however you want ;-) Check out http://www.csszengarden.com/ for examples of how all elements can be completely changed by artistic CSS design alone. But I don't know where you're at with fixing up styles in the code, I'm just getting into it. From reading the themes docs, it might not be that hard to have colours as currently defined becoming styles completely. This is the sort of thing I could quite easily handle in a bit of spare time here and there, if anyone is interested in taking it further? Regards, -- Simon White. Internet Consultant, Linux/Windows Server Administration. email, dns and web servers; php javascript perl asp; MySQL MSSQL Access Bridging the gap between management, HR and the tech team. |
From: Jonathan A. <jo...@sq...> - 2003-12-03 08:32:57
|
On Wed, 2003-12-03 at 02:11, Simon White wrote: > > I don't see a problem with at least making it optional. Everybody has a > > preference, they all seem slightly varied on here... some want it > > centered, some left, some right... Shouldn't be difficult to just add a > > case statement in there, and a user preferences... probably a total of > > 20 lines of code at the most, and everybody is happy then. > > IMHO, this kind of thing should entirely be handled in CSS. > > Each element should belong to a class, and those classes should have > their styles. Then, switching CSS stylesheets could align whatever > wherever however you want ;-) The only problem I can see with this is... it's customizable per system/css sheet... not per user, unless you want to allow them to modify CSS sheets, and upload them onto the server. Or am I wrong there? At least with an option as I was suggesting it, it's a drop down list. -- Jonathan Angliss (jo...@sq...) |
From: Simon W. <si...@ca...> - 2003-12-03 08:50:49
|
03-Dec-03 at 02:34, Jonathan Angliss (jo...@sq...) wrote : > On Wed, 2003-12-03 at 02:11, Simon White wrote: > > > I don't see a problem with at least making it optional. Everybody has a > > > preference, they all seem slightly varied on here... some want it > > > centered, some left, some right... Shouldn't be difficult to just add a > > > case statement in there, and a user preferences... probably a total of > > > 20 lines of code at the most, and everybody is happy then. > > > > IMHO, this kind of thing should entirely be handled in CSS. > > > > Each element should belong to a class, and those classes should have > > their styles. Then, switching CSS stylesheets could align whatever > > wherever however you want ;-) > > The only problem I can see with this is... it's customizable per > system/css sheet... not per user, unless you want to allow them to > modify CSS sheets, and upload them onto the server. Or am I wrong > there? At least with an option as I was suggesting it, it's a drop down > list. Well CSS can be applied user end in a browser, but that's unlikely to happen for any but the most power HTML/CSS users. But if we break themes into 1) Colour scheme (easy theme) 2) Fonts & alignment + colours (moderate theme) - parts of this could default to a CSS style sheet which, if users really want it, could be overidden by a few limited user options (date alignment is one thing, maybe date format changes too, like mm/dd/yyy or dd/mm/yyyy or RFC email date format etc etc) 3) CSS wizardry (hardcore theming) But in the end, maybe generating a user.css would make sense. I have a feeling a default.css included first would be overridden by a user.css included after it, and that file could just change those things necessary. I'll test this later and let you know. Regards, -- Simon White. Internet Consultant, Linux/Windows Server Administration. email, dns and web servers; php javascript perl asp; MySQL MSSQL Access Bridging the gap between management, HR and the tech team. |
From: Tomas K. <to...@us...> - 2003-12-03 09:12:18
|
> IMHO, this kind of thing should entirely be handled in CSS. > > Each element should belong to a class, and those classes should have > their styles. Then, switching CSS stylesheets could align whatever > wherever however you want ;-) One problem. I think, CSS does not detect Right-To-Left languages. You will need two stylesheets. One for Left-To-Right and one for Right-To-Left. Unless you know how to use same css with alignment settings in English and Arabic, alignment has to be done in php. -- Tomas |
From: Simon W. <si...@ca...> - 2003-12-03 10:40:46
|
03-Dec-03 at 11:14, Tomas Kuliavas (to...@us...) wrote : > > IMHO, this kind of thing should entirely be handled in CSS. > > > > Each element should belong to a class, and those classes should have > > their styles. Then, switching CSS stylesheets could align whatever > > wherever however you want ;-) > > One problem. I think, CSS does not detect Right-To-Left languages. You > will need two stylesheets. One for Left-To-Right and one for > Right-To-Left. > > Unless you know how to use same css with alignment settings in English and > Arabic, alignment has to be done in php. Alignment is done in HTML, rather than PHP, I suppose? I'll have to take a deeper look into how you handle Arabic and Hebrew (and any other RtoL languages) first, and come back to you. You can set style independently of the master CSS so this shouldn't be a blocker, for example see: http://www.webreference.com/programming/corecss/2/ I'll have a look around. -- Simon White. Internet Consultant, Linux/Windows Server Administration. email, dns and web servers; php javascript perl asp; MySQL MSSQL Access Bridging the gap between management, HR and the tech team. |
From: Simon W. <si...@ca...> - 2003-12-03 11:01:55
|
03-Dec-03 at 16:40, Simon White (si...@ca...) wrote : > 03-Dec-03 at 11:14, Tomas Kuliavas (to...@us...) wrote : > > One problem. I think, CSS does not detect Right-To-Left languages. You > > will need two stylesheets. One for Left-To-Right and one for > > Right-To-Left. > > > > Unless you know how to use same css with alignment settings in English and > > Arabic, alignment has to be done in php. > > I'll have to take a deeper look into how you handle Arabic and Hebrew > (and any other RtoL languages) first, and come back to you. You can set > style independently of the master CSS so this shouldn't be a blocker, > for example see: > > http://www.webreference.com/programming/corecss/2/ After checking, it appears to me that the rtl languages are happy with CSS, and the alignment properties could just as easily be set by choosing the relevant alignment somehow... html.php sets alignment in the HTML tag and could easily set alignment correctly. CSS should, given justify=right, work out the text direction and act accordingly? Cheers, -- Simon White. Internet Consultant, Linux/Windows Server Administration. email, dns and web servers; php javascript perl asp; MySQL MSSQL Access Bridging the gap between management, HR and the tech team. |
From: Daniel W <dan...@li...> - 2003-12-05 23:08:03
|
Very well said Brian =) > Can anybody think of a good reason NOT to change to right alignment? > > I've only heard reasons TO make the change. If this is the case, then why > waste any more time on it? > > Regards, > > - Brian |