From: Paul L. <pa...@sq...> - 2011-12-30 20:42:58
|
All, See: https://sourceforge.net/tracker/index.php?func=detail&aid=3240356&group_id=311&atid=423679 SquirrelMail version 1.4.x renders in "quirks" mode, and ideally we'd render in "standards" mode. The fix is easy - a small change to the DOCTYPE (patch attached to the tracker), HOWEVER, the change could have consequences for plugins (especially ones that use certain CSS or JavaScript) and even for untested parts of the core. Since changing the DOCTYPE affects every single page created by SquirrelMail, I'm not so sure we should make this change in the STABLE branch. Opinions? -- Paul Lesniewski SquirrelMail Team Please support Open Source Software by donating to SquirrelMail! http://squirrelmail.org/donate_paul_lesniewski.php |
From: phil <ph...@di...> - 2011-12-31 11:09:12
|
On Friday 30 Dec 2011, Paul Lesniewski wrote: > All, > > See: > https://sourceforge.net/tracker/index.php?func=detail&aid=3240356&group_id > =311&atid=423679 > > SquirrelMail version 1.4.x renders in "quirks" mode, and ideally > we'd render in "standards" mode. The fix is easy - a small change to > the DOCTYPE (patch attached to the tracker), HOWEVER, the change could > have consequences for plugins (especially ones that use certain CSS or > JavaScript) and even for untested parts of the core. > > Since changing the DOCTYPE affects every single page created by > SquirrelMail, I'm not so sure we should make this change in the STABLE > branch. > > Opinions? I would suggest that you ask for volunteers and developers on the plugin list to apply the patch and report any problems they find, and then make a decision based on the feeback from that exercise. For what it's worth, I've applied the patch to all my installations and have noticed no change in behaviour at all on a range of desktop and mobile browsers, however I'm only using plugins supplied as standard with Squirrelmail. -- Phil Driscoll |
From: Tomas K. <to...@us...> - 2011-12-31 11:49:20
|
Bugzilla from ph...@di... wrote: > > I've applied the patch to all my installations and have noticed no change > in behaviour > Image Buttons plugin. -- View this message in context: http://old.nabble.com/Changing-STABLE-DOCTYPE--tp33056554p33058753.html Sent from the squirrelmail-devel mailing list archive at Nabble.com. |
From: Michael A. P. I. <sha...@gm...> - 2012-01-02 09:34:26
|
On Fri, 30 Dec 2011 15:42:31 -0500, Paul Lesniewski <pa...@sq...> wrote: > SquirrelMail version 1.4.x renders in "quirks" mode, and ideally > we'd render in "standards" mode. > > Opinions? Opera has a quirks mode font-size regression bug that makes the body text bigger compared to other browsers. I've been trying to get Opera to fix it for years but they just won't do it. :( Opera has <opera:config#browser%20css%20file> where you can patch Opera's default style sheet. However, browser.css doesn't have any way to differentiate between quirks mode and standards mode. So, if you fix the font-size for quirks mode, you'll break something in standards mode and vice versa. I asked the Opera devs if they'd implement something for browser.css to differentiate between quirks mode and standards mode so users could at least fix it themselves and they said it could be easily implemented. But, the whole proposal was denied. In short, there's no way to fix it for Opera except for making the page run in standards mode or by using user css or user js in a site preference. I've been patching Squirrelmail for a long time now to make it run in standards mode to fix things for Opera. I think it'd be great if SquirrelMail did this by default. -- Michael |
From: Paul L. <pa...@sq...> - 2012-01-02 23:02:48
|
On Mon, Jan 2, 2012 at 1:34 AM, Michael A. Puls II <sha...@gm...> wrote: > On Fri, 30 Dec 2011 15:42:31 -0500, Paul Lesniewski <pa...@sq...> > wrote: > >> SquirrelMail version 1.4.x renders in "quirks" mode, and ideally >> we'd render in "standards" mode. >> >> Opinions? > > > Opera has a quirks mode font-size regression bug that makes the body text > bigger compared to other browsers. I've been trying to get Opera to fix it > for years but they just won't do it. :( > > Opera has <opera:config#browser%20css%20file> where you can patch Opera's > default style sheet. However, browser.css doesn't have any way to > differentiate between quirks mode and standards mode. So, if you fix the > font-size for quirks mode, you'll break something in standards mode and vice > versa. > > I asked the Opera devs if they'd implement something for browser.css to > differentiate between quirks mode and standards mode so users could at least > fix it themselves and they said it could be easily implemented. But, the > whole proposal was denied. > > In short, there's no way to fix it for Opera except for making the page run > in standards mode or by using user css or user js in a site preference. > > I've been patching Squirrelmail for a long time now to make it run in > standards mode to fix things for Opera. I think it'd be great if > SquirrelMail did this by default. I'm going to propose a configuration setting so those who want to can change to standards mode. Please try the attached patch (against version 1.4.23-svn) and let me know if there are any problems. Thanks. -- Paul Lesniewski SquirrelMail Team Please support Open Source Software by donating to SquirrelMail! http://squirrelmail.org/donate_paul_lesniewski.php |
From: Michael A. P. I. <sha...@gm...> - 2012-01-03 04:23:47
|
On Mon, 02 Jan 2012 18:02:20 -0500, Paul Lesniewski <pa...@sq...> wrote: > On Mon, Jan 2, 2012 at 1:34 AM, Michael A. Puls II > <sha...@gm...> wrote: >> On Fri, 30 Dec 2011 15:42:31 -0500, Paul Lesniewski >> <pa...@sq...> >> wrote: > >> I've been patching Squirrelmail for a long time now to make it run in >> standards mode to fix things for Opera. I think it'd be great if >> SquirrelMail did this by default. > > I'm going to propose a configuration setting so those who want to can > change to standards mode. Please try the attached patch (against > version 1.4.23-svn) and let me know if there are any problems. Will do. -- Michael |
From: Michael A. P. I. <sha...@gm...> - 2012-01-03 07:16:13
|
On Mon, 02 Jan 2012 23:23:39 -0500, Michael A. Puls II <sha...@gm...> wrote: > On Mon, 02 Jan 2012 18:02:20 -0500, Paul Lesniewski > <pa...@sq...> wrote: > >> On Mon, Jan 2, 2012 at 1:34 AM, Michael A. Puls II >> <sha...@gm...> wrote: >>> On Fri, 30 Dec 2011 15:42:31 -0500, Paul Lesniewski >>> <pa...@sq...> >>> wrote: >> >>> I've been patching Squirrelmail for a long time now to make it run in >>> standards mode to fix things for Opera. I think it'd be great if >>> SquirrelMail did this by default. >> >> I'm going to propose a configuration setting so those who want to can >> change to standards mode. Please try the attached patch (against >> version 1.4.23-svn) and let me know if there are any problems. > > Will do. I tested. The patch works fine and makes the option available when configuring. Setting it to true makes the pages have: <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd"> , which puts the pages in standards mode, which also avoids the Opera quirks mode font-size bug. I also didn't notice any issues with the display of messages or preference pages or message detail and message header plug-in pages etc. However, the transitional doctype (with the loose dtd URI specified) only triggers "almost standards mode" (see <http://hsivonen.iki.fi/doctype/>). A regular HTML 4.01 doctype with the strict dtd URI should trigger full standards mode. But, so will "<!DOCTYPE html>". As mentioned on the page, the main difference between standards mode and almost standards mode is the handling of images and alignment. If it's not a problem, it'd be best to shoot for full standards mode (or allow the choice between quirks, almost standards and standards modes). -- Michael |
From: Paul L. <pa...@sq...> - 2012-01-03 19:10:08
|
>>>> I've been patching Squirrelmail for a long time now to make it run in >>>> standards mode to fix things for Opera. I think it'd be great if >>>> SquirrelMail did this by default. >>> >>> I'm going to propose a configuration setting so those who want to can >>> change to standards mode. Please try the attached patch (against >>> version 1.4.23-svn) and let me know if there are any problems. > > I tested. The patch works fine and makes the option available when > configuring. Setting it to true makes the pages have: > > <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" > "http://www.w3.org/TR/html4/loose.dtd"> > > , which puts the pages in standards mode, which also avoids the Opera quirks > mode font-size bug. I also didn't notice any issues with the display of > messages or preference pages or message detail and message header plug-in > pages etc. > > However, the transitional doctype (with the loose dtd URI specified) only > triggers "almost standards mode" (see <http://hsivonen.iki.fi/doctype/>). A > regular HTML 4.01 doctype with the strict dtd URI should trigger full > standards mode. But, so will "<!DOCTYPE html>". As mentioned on the page, > the main difference between standards mode and almost standards mode is the > handling of images and alignment. If it's not a problem, it'd be best to > shoot for full standards mode (or allow the choice between quirks, almost > standards and standards modes). I suppose you're right; since SquirrelMail doesn't use any sliced images, I didn't give much credence to the difference between loose/strict. I'm changing the patch to allow for quirks, almost standards and standards. I don't know as it makes much sense to allow HTML5, but that could be added more easily to this scheme as well. Please revert the last patch and try the one attached to this message. Thank you. -- Paul Lesniewski SquirrelMail Team Please support Open Source Software by donating to SquirrelMail! http://squirrelmail.org/donate_paul_lesniewski.php |
From: Michael A. P. I. <sha...@gm...> - 2012-01-04 09:05:00
|
On Tue, 03 Jan 2012 14:09:39 -0500, Paul Lesniewski <pa...@sq...> wrote: >>>>> I've been patching Squirrelmail for a long time now to make it run in >>>>> standards mode to fix things for Opera. I think it'd be great if >>>>> SquirrelMail did this by default. >>>> >>>> I'm going to propose a configuration setting so those who want to can >>>> change to standards mode. Please try the attached patch (against >>>> version 1.4.23-svn) and let me know if there are any problems. >> >> I tested. The patch works fine and makes the option available when >> configuring. Setting it to true makes the pages have: >> >> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" >> "http://www.w3.org/TR/html4/loose.dtd"> >> >> , which puts the pages in standards mode, which also avoids the Opera >> quirks >> mode font-size bug. I also didn't notice any issues with the display of >> messages or preference pages or message detail and message header >> plug-in >> pages etc. >> >> However, the transitional doctype (with the loose dtd URI specified) >> only >> triggers "almost standards mode" (see >> <http://hsivonen.iki.fi/doctype/>). A >> regular HTML 4.01 doctype with the strict dtd URI should trigger full >> standards mode. But, so will "<!DOCTYPE html>". As mentioned on the >> page, >> the main difference between standards mode and almost standards mode is >> the >> handling of images and alignment. If it's not a problem, it'd be best to >> shoot for full standards mode (or allow the choice between quirks, >> almost >> standards and standards modes). > > I suppose you're right; since SquirrelMail doesn't use any sliced > images, I didn't give much credence to the difference between > loose/strict. I'm changing the patch to allow for quirks, almost > standards and standards. I don't know as it makes much sense to allow > HTML5, but that could be added more easily to this scheme as well. O.K. > Please revert the last patch and try the one attached to this message. Patch works fine. All 3 options work fine and produce the correct doctype. And, if you use something other than "quirks", "standards" or "almost" like "zipzambam", it defaults to quirks, which makes sense. I did find a few super-minor issues though: * With "almost" and "standards" mode, on the "options -> display preferences" page, the checkboxes at the bottom are not aligned as intended. They're shifted to the right a bit. * With "standards" mode, on the message page where you have "message list", "Unread", "Delete", "Previous", "Next" etc. links, the container those links are in becomes a tad bit taller. You can tell because the gray background gets a tad bit taller. * The day number links in the cells for the calendar plug-in are shifted down a few pixels in "standards" mode. Nothing major. -- Michael |
From: Michael A. P. I. <sha...@gm...> - 2012-01-04 10:56:47
|
On Wed, 04 Jan 2012 04:04:51 -0500, Michael A. Puls II <sha...@gm...> wrote: > * With "almost" and "standards" mode, on the "options -> display > preferences" page, the checkboxes at the bottom are not aligned as > intended. They're shifted to the right a bit. Setting text-align: left for the td they're in seems to fix that btw. -- Michael |
From: Paul L. <pa...@sq...> - 2012-01-04 20:58:42
|
On Wed, Jan 4, 2012 at 1:04 AM, Michael A. Puls II <sha...@gm...> wrote: > On Tue, 03 Jan 2012 14:09:39 -0500, Paul Lesniewski <pa...@sq...> > wrote: > >>>>>> I've been patching Squirrelmail for a long time now to make it run in >>>>>> standards mode to fix things for Opera. I think it'd be great if >>>>>> SquirrelMail did this by default. >>>>> >>>>> >>>>> I'm going to propose a configuration setting so those who want to can >>>>> change to standards mode. Please try the attached patch (against >>>>> version 1.4.23-svn) and let me know if there are any problems. >>> >>> >>> I tested. The patch works fine and makes the option available when >>> configuring. Setting it to true makes the pages have: >>> >>> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" >>> "http://www.w3.org/TR/html4/loose.dtd"> >>> >>> , which puts the pages in standards mode, which also avoids the Opera >>> quirks >>> mode font-size bug. I also didn't notice any issues with the display of >>> messages or preference pages or message detail and message header plug-in >>> pages etc. >>> >>> However, the transitional doctype (with the loose dtd URI specified) only >>> triggers "almost standards mode" (see <http://hsivonen.iki.fi/doctype/>). >>> A >>> regular HTML 4.01 doctype with the strict dtd URI should trigger full >>> standards mode. But, so will "<!DOCTYPE html>". As mentioned on the >>> page, >>> the main difference between standards mode and almost standards mode is >>> the >>> handling of images and alignment. If it's not a problem, it'd be best to >>> shoot for full standards mode (or allow the choice between quirks, almost >>> standards and standards modes). >> >> >> I suppose you're right; since SquirrelMail doesn't use any sliced >> images, I didn't give much credence to the difference between >> loose/strict. I'm changing the patch to allow for quirks, almost >> standards and standards. I don't know as it makes much sense to allow >> HTML5, but that could be added more easily to this scheme as well. This patch has been committed to 1.4.23-svn repository. The final change was slightly different than this patch and the parent frameset is also affected (not in this patch). Cheers, -- Paul Lesniewski SquirrelMail Team Please support Open Source Software by donating to SquirrelMail! http://squirrelmail.org/donate_paul_lesniewski.php |
From: Michael A. P. I. <sha...@gm...> - 2012-01-05 11:22:07
|
On Wed, 04 Jan 2012 15:58:11 -0500, Paul Lesniewski <pa...@sq...> wrote: > This patch has been committed to 1.4.23-svn repository. The final > change was slightly different than this patch and the parent frameset > is also affected (not in this patch). I tested the newest build. It works fine too and "standards" works as intended. I can also confirm the dtd URI for the frameset doctype is now present and that the frame page is in standards mode. -- Michael |
From: Paul L. <pa...@sq...> - 2012-01-05 18:51:43
|
On Thu, Jan 5, 2012 at 3:21 AM, Michael A. Puls II <sha...@gm...> wrote: > On Wed, 04 Jan 2012 15:58:11 -0500, Paul Lesniewski <pa...@sq...> > wrote: > >> This patch has been committed to 1.4.23-svn repository. The final >> change was slightly different than this patch and the parent frameset >> is also affected (not in this patch). > > > I tested the newest build. It works fine too and "standards" works as > intended. I can also confirm the dtd URI for the frameset doctype is now > present and that the frame page is in standards mode. Thank you for your help and feedback. -- Paul Lesniewski SquirrelMail Team Please support Open Source Software by donating to SquirrelMail! http://squirrelmail.org/donate_paul_lesniewski.php |