From: Thierry G. <mel...@ya...> - 2008-01-08 08:47:59
Attachments:
squirrelmail-20080107-SVN_devel-Tree.patch
|
Greetings, I found two bugs in the SVN devel branch of sqm (2008/01/07 checkout): 1.- From the "Folders" menu, when deleting a folder containing some messages, you get the following error: Fatal error: Call to undefined function: sqimap_msgs_list_copy() in /.../.../functions/tree.php on line 174 See the attached patch for a fix. Given sqimap_run_command() is also used in tree.php and might result in another undefined function error somewhere else in the code, I require imap.php and not only imap_messages.php. 2.- From the message list, when deleting some messages without sending them to the trash folder, I -sometimes- get the following notice: Catégorie : PHP Message : Undefined index: TOTAL FILE: /home/melinda/www/SquirrelMail-devel/html/functions/mailbox_display.php LINE: 1475 Catégorie : PHP Message : Undefined offset: 0 FILE: /home/melinda/www/SquirrelMail-devel/html/functions/mailbox_display.php LINE: 1475 Context: - The mailbox contains more than two messages. - I check the first two message in the list, I check the "don't send to trash" check box, and I press the delete button. This has been tested on several mailboxes, with various messages, but I could not find any reliable way to reproduce this bug (it happens about 50% of the time). Regards, Thierry Godefroy. ____________________________________________________________________________________ Looking for last minute shopping deals? Find them fast with Yahoo! Search. http://tools.search.yahoo.com/newsearch/category.php?category=shopping |
From: Thierry G. <mel...@ya...> - 2008-01-11 08:44:46
|
Hello, Here is a fix (or more likely a work around) for the message deletion bug I signaled a few days ago (see below). Regards, Thierry Godefroy. --- Thierry Godefroy <mel...@ya...> wrote: > Greetings, > > I found two bugs in the SVN devel branch of sqm (2008/01/07 checkout): > > 1.- From the "Folders" menu, when deleting a folder containing some messages, > you get the following error: > > Fatal error: Call to undefined function: sqimap_msgs_list_copy() in > /.../.../functions/tree.php on line 174 > > See the attached patch for a fix. Given sqimap_run_command() is also used in > tree.php and might result in another undefined function error somewhere else > in the code, I require imap.php and not only imap_messages.php. > > > 2.- From the message list, when deleting some messages without sending them > to the trash folder, I -sometimes- get the following notice: > > Catégorie : PHP > Message : Undefined index: TOTAL > FILE: > /home/melinda/www/SquirrelMail-devel/html/functions/mailbox_display.php > LINE: 1475 > Catégorie : PHP > Message : Undefined offset: 0 > FILE: > /home/melinda/www/SquirrelMail-devel/html/functions/mailbox_display.php > LINE: 1475 > > Context: > - The mailbox contains more than two messages. > - I check the first two message in the list, I check the "don't send to > trash" check box, and I press the delete button. > > This has been tested on several mailboxes, with various messages, but I could > not find any reliable way to reproduce this bug (it happens about 50% of the > time). > > Regards, > > Thierry Godefroy. ____________________________________________________________________________________ Never miss a thing. Make Yahoo your home page. http://www.yahoo.com/r/hs |
From: Thijs K. <ki...@sq...> - 2008-01-24 11:20:45
|
Hi Thierry, On Friday 11 January 2008 09:44, Thierry Godefroy wrote: > Here is a fix (or more likely a work around) for the message deletion bug= I > signaled a few days ago (see below). This indeed more hides a bug than solves it. I would appreciate it if you=20 could file a bug report about it with details (I don't have more time to lo= ok=20 into it now, and this ensures it's not lost). thanks, Thijs |
From: Thierry G. <mel...@ya...> - 2008-01-24 13:29:00
|
--- Thijs Kinkhorst <ki...@sq...> wrote: > Hi Thierry, > > On Friday 11 January 2008 09:44, Thierry Godefroy wrote: > > Here is a fix (or more likely a work around) for the message deletion bug I > > signaled a few days ago (see below). > > This indeed more hides a bug than solves it. I would appreciate it if you > could file a bug report about it with details (I don't have more time to look > into it now, and this ensures it's not lost). Well, the bug report was already in my original email... I will see what I can do, but don't hold your breath: I'm a very busy man too. ;-P Regards, Thierry Godefroy. ____________________________________________________________________________________ Be a better friend, newshound, and know-it-all with Yahoo! Mobile. Try it now. http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ |
From: Paul L. <pa...@sq...> - 2008-01-30 00:05:31
|
On Jan 24, 2008 5:28 AM, Thierry Godefroy <mel...@ya...> wrote: > > > --- Thijs Kinkhorst <ki...@sq...> wrote: > > > Hi Thierry, > > > > On Friday 11 January 2008 09:44, Thierry Godefroy wrote: > > > Here is a fix (or more likely a work around) for the message deletion bug I > > > signaled a few days ago (see below). > > > > This indeed more hides a bug than solves it. I would appreciate it if you > > could file a bug report about it with details (I don't have more time to look > > into it now, and this ensures it's not lost). > > Well, the bug report was already in my original email... I will see what I can > do, but don't hold your breath: I'm a very busy man too. ;-P https://sourceforge.net/tracker/index.php?func=detail&aid=1882247&group_id=311&atid=100311 |
From: Thijs K. <ki...@sq...> - 2008-01-24 11:19:09
|
Hi Thierry, On Tuesday 8 January 2008 09:47, Thierry Godefroy wrote: > 1.- From the "Folders" menu, when deleting a folder containing some > messages, you get the following error: > > Fatal error: Call to undefined function: sqimap_msgs_list_copy() in > /.../.../functions/tree.php on line 174 > > See the attached patch for a fix. Given sqimap_run_command() is also used > in tree.php and might result in another undefined function error somewhere > else in the code, I require imap.php and not only imap_messages.php. I can't reproduce this problem myself. However this could be caused by a=20 combination of plugins or IMAP-server-specific handling. In any case, I agr= ee=20 that tree.php always requires those functions, so I've added the require_on= ce=20 to the top of the file. Thanks! Thijs |