From: Scott B. <br...@tr...> - 2000-12-07 22:49:33
|
Hello. I just installed SquirrelMail on my home machine and so far I am very impressed with it. Great work! I made the following change to integrate SquirrelMail better with my site. Now, when they click logout, uers are returned to their home pages. The current SquirrelMail signout page is a bit short on things for the user to do. :) Please tell me what I would need to do to have this patch applied. Thanks! - Scott Index: config/config_default.php =================================================================== RCS file: /cvsroot/squirrelmail/squirrelmail/config/config_default.php,v retrieving revision 1.34 diff -u -r1.34 config_default.php --- config/config_default.php 2000/10/17 18:15:35 1.34 +++ config/config_default.php 2000/12/07 22:35:10 @@ -56,6 +56,14 @@ // uw $imap_server_type = "cyrus"; +// Rather than going to the signout.php page (which only allows you +// to sign back in), setting signout_location allows you to sign +// the user out and then redirect to whatever page you want. +// For instance, the following would return the user to your +// home page: $signout_location = "/"; +// Set to the empty string to continue to use the default signout page. + $signout_location = ""; + // Many servers store mail in your home directory. With this, they // store them in a subdirectory: mail/ or Mail/, etc. If your // server does this, please set this to what the default mail folder Index: src/signout.php =================================================================== RCS file: /cvsroot/squirrelmail/squirrelmail/src/signout.php,v retrieving revision 1.20 diff -u -r1.20 signout.php --- src/signout.php 2000/10/21 16:08:31 1.20 +++ src/signout.php 2000/12/07 22:35:10 @@ -30,6 +30,12 @@ setcookie("key", "", 0, $base_uri); setcookie("logged_in", "", 0, $base_uri); session_destroy(); + + if ($signout_location) { + header("Status: 303 See Other"); + header("Location: $signout_location"); + exit; /* we send no content if we're redirecting. */ + } ?> <HTML> <HEAD> |
From: Lewis B. <lbe...@ab...> - 2000-12-08 02:19:36
|
On Thu, 07 Dec 2000, you wrote: > Hello. I just installed SquirrelMail on my home machine and so > far I am very impressed with it. Great work! > > I made the following change to integrate SquirrelMail better with my > site. Now, when they click logout, uers are returned to their home > pages. The current SquirrelMail signout page is a bit short on things > for the user to do. :) > > Please tell me what I would need to do to have this patch applied. > Thanks! > > I can say with certainty that this will not be applied as a patch. Well, I shouldn't say that, I don't think it will. This is easily done as a plugin. We will post that to the site. Please see the plugin docs for more info on that. -- Lewis Bergman Texas Communications 4309 Maple St. Abilene, TX 79602 915-695-6962 |
From: Scott B. <br...@tr...> - 2000-12-11 18:16:30
|
I looked carefully at the SquirrelMail plugin architecture over the weekend and came away very impressed. It's possible to write some very sophisticated plugins in Squirrelmail. And, setting the signout location would indeed be a trivial plugin to write. However, just because it's easy to write as a plugin doesn't mean it SHOULD be a plugin. Plugins are maintenance nightmares. They conflict with different versions of SquirrelMail and each other. They have hidden order dependencies. They must be dilligently updated since SquirrelMail developers certainly won't ensure every plugin still works before CVS Committing. And, they are a drag to apply. When bringing up a new SquirrelMail site, I don't mind applying two or three plugins, but applying a whole mess of them just to get some basic features? I would be beta testing your code, since it's highly unlikely that anybody would have tested my particular combination of plugins before. The language translator plugin is an _excellent_ example of the power and flexibility of this architecture. The six-line patch that I submitted, alas, is not. - Scott > > > Hello. I just installed SquirrelMail on my home machine and so > > far I am very impressed with it. Great work! > > > > I made the following change to integrate SquirrelMail better with my > > site. Now, when they click logout, uers are returned to their home > > pages. The current SquirrelMail signout page is a bit short on things > > for the user to do. :) > > > > Please tell me what I would need to do to have this patch applied. > > Thanks! > > > > > I can say with certainty that this will not be applied as a patch. Well, I > shouldn't say that, I don't think it will. > > This is easily done as a plugin. We will post that to the site. Please see the > plugin docs for more info on that. > > -- > Lewis Bergman > Texas Communications > 4309 Maple St. > Abilene, TX 79602 > 915-695-6962 > |
From: Lewis B. <lbe...@ab...> - 2000-12-11 19:28:40
|
On Mon, 11 Dec 2000, you wrote: > I looked carefully at the SquirrelMail plugin architecture over the > weekend and came away very impressed. It's possible to write some > very sophisticated plugins in Squirrelmail. And, setting the signout > location would indeed be a trivial plugin to write. > > However, just because it's easy to write as a plugin doesn't mean it > SHOULD be a plugin. > > Plugins are maintenance nightmares. They conflict with different > versions of SquirrelMail and each other. They have hidden order > dependencies. They must be dilligently updated since SquirrelMail > developers certainly won't ensure every plugin still works before > CVS Committing. And, they are a drag to apply. When bringing up > a new SquirrelMail site, I don't mind applying two or three plugins, > but applying a whole mess of them just to get some basic features? > I would be beta testing your code, since it's highly unlikely that > anybody would have tested my particular combination of plugins > before. > > The language translator plugin is an _excellent_ example of the > power and flexibility of this architecture. The six-line patch > that I submitted, alas, is not. Maybe a better solution is to have an admin configured var for the signout page. That would allow many possibilities and still be defaulted to the way it is now. In any case, it will have to wait till after 1.0 -- Lewis Bergman Texas Communications 4309 Maple St. Abilene, TX 79602 915-695-6962 |
From: Scott B. <br...@tr...> - 2000-12-11 22:05:18
|
> Maybe a better solution is to have an admin configured var for the signout page. > That would allow many possibilities and still be defaulted to the way it is > now. Did you even look at the patch? That's exactly the way it works. I'm glad we agree. - Scott P.S. Is there any chance of getting this in with the other patches being applied now? It's quite small and innocouous... Index: config/config_default.php =================================================================== RCS file: /cvsroot/squirrelmail/squirrelmail/config/config_default.php,v retrieving revision 1.34 diff -u -r1.34 config_default.php --- config/config_default.php 2000/10/17 18:15:35 1.34 +++ config/config_default.php 2000/12/07 22:35:10 @@ -56,6 +56,14 @@ // uw $imap_server_type = "cyrus"; +// Rather than going to the signout.php page (which only allows you +// to sign back in), setting signout_location allows you to sign +// the user out and then redirect to whatever page you want. +// For instance, the following would return the user to your +// home page: $signout_location = "/"; +// Set to the empty string to continue to use the default signout page. + $signout_location = ""; + // Many servers store mail in your home directory. With this, they // store them in a subdirectory: mail/ or Mail/, etc. If your // server does this, please set this to what the default mail folder Index: src/signout.php =================================================================== RCS file: /cvsroot/squirrelmail/squirrelmail/src/signout.php,v retrieving revision 1.20 diff -u -r1.20 signout.php --- src/signout.php 2000/10/21 16:08:31 1.20 +++ src/signout.php 2000/12/07 22:35:10 @@ -30,6 +30,12 @@ setcookie("key", "", 0, $base_uri); setcookie("logged_in", "", 0, $base_uri); session_destroy(); + + if ($signout_location) { + header("Status: 303 See Other"); + header("Location: $signout_location"); + exit; /* we send no content if we're redirecting. */ + } ?> <HTML> <HEAD> |
From: Paul J. T. <th...@ok...> - 2000-12-11 22:54:45
|
> P.S. Is there any chance of getting this in with the > other patches being applied now? It's quite small and > innocouous... This patch looks pretty good to me. I don't have the time to apply it right now, due to a hectic finals week. Luke, if you have time, could you see that this gets applied? -- Paul Joseph Thompson Oklahoma State University th...@ok... |
From: Lewis B. <lbe...@ab...> - 2000-12-11 23:00:38
|
On Mon, 11 Dec 2000, you wrote: > > Maybe a better solution is to have an admin configured var for the signout page. > > That would allow many possibilities and still be defaulted to the way it is > > now. > > Did you even look at the patch? That's exactly the way it works. > I'm glad we agree. > I can't even find it on the patch manager. Did you submit it there or just to the mail list? I seldom read patches sent to the list. > P.S. Is there any chance of getting this in with the other patches > being applied now? It's quite small and innocouous... > I doubt it. Just because of the feature freeze. The patches which were pushed through were done so on the basis that they were submitted a while back and we were lazy about reviewing them. You are not the only one to be left out. another was rejected on the basis of security. No matter how small there is a chance a new bug will be introduced. The redirect.php reintroduced the qoutemeta bug for instance. In the meantime if you know perl it might be good to make this an option in that to go along with your default_config change. I am no perl programer so I couldn't begin to talk about how to do that. -- Lewis Bergman Texas Communications 4309 Maple St. Abilene, TX 79602 915-695-6962 |
From: Luke E. <leh...@cs...> - 2000-12-12 00:02:36
|
I do like your patch, however, I'm afraid I'm going to have to be a stickler and say that we can't apply it due to the feature freeze. However, could I request that you do submit it to our patch manager on sourceforge so that after 1.0 is released, we could add this to one of the future releases of the 1.x branch? Thank you, Luke On Mon, 11 Dec 2000, Scott Bronson wrote: > > Maybe a better solution is to have an admin configured var for the signout page. > > That would allow many possibilities and still be defaulted to the way it is > > now. > > Did you even look at the patch? That's exactly the way it works. > I'm glad we agree. > > - Scott > > > P.S. Is there any chance of getting this in with the other patches > being applied now? It's quite small and innocouous... > > > Index: config/config_default.php > =================================================================== > RCS file: /cvsroot/squirrelmail/squirrelmail/config/config_default.php,v > retrieving revision 1.34 > diff -u -r1.34 config_default.php > --- config/config_default.php 2000/10/17 18:15:35 1.34 > +++ config/config_default.php 2000/12/07 22:35:10 > @@ -56,6 +56,14 @@ > // uw > $imap_server_type = "cyrus"; > > +// Rather than going to the signout.php page (which only allows you > +// to sign back in), setting signout_location allows you to sign > +// the user out and then redirect to whatever page you want. > +// For instance, the following would return the user to your > +// home page: $signout_location = "/"; > +// Set to the empty string to continue to use the default signout page. > + $signout_location = ""; > + > // Many servers store mail in your home directory. With this, they > // store them in a subdirectory: mail/ or Mail/, etc. If your > // server does this, please set this to what the default mail folder > Index: src/signout.php > =================================================================== > RCS file: /cvsroot/squirrelmail/squirrelmail/src/signout.php,v > retrieving revision 1.20 > diff -u -r1.20 signout.php > --- src/signout.php 2000/10/21 16:08:31 1.20 > +++ src/signout.php 2000/12/07 22:35:10 > @@ -30,6 +30,12 @@ > setcookie("key", "", 0, $base_uri); > setcookie("logged_in", "", 0, $base_uri); > session_destroy(); > + > + if ($signout_location) { > + header("Status: 303 See Other"); > + header("Location: $signout_location"); > + exit; /* we send no content if we're redirecting. */ > + } > ?> > <HTML> > <HEAD> > > > -- _ . . Luke Ehresman - "Codito, ergo sum" / v \ leh...@cs... /( )\ http://www.css.tayloru.edu/~lehresma ^^ ^^ |
From: Scott B. <br...@tr...> - 2000-12-12 21:45:24
|
OK, I'll update the config Perl script (as suggested by Lewis) and submit it to the Patch Manager for later consideration. - Scott > I do like your patch, however, I'm afraid I'm going to have to be a stickler > and say that we can't apply it due to the feature freeze. However, could I > request that you do submit it to our patch manager on sourceforge so that > after 1.0 is released, we could add this to one of the future releases of > the 1.x branch? > > Thank you, > Luke > > > On Mon, 11 Dec 2000, Scott Bronson wrote: > > > > Maybe a better solution is to have an admin configured var for the signout page. > > > That would allow many possibilities and still be defaulted to the way it is > > > now. > > > > Did you even look at the patch? That's exactly the way it works. > > I'm glad we agree. > > > > - Scott > > > > > > P.S. Is there any chance of getting this in with the other patches > > being applied now? It's quite small and innocouous... > > > > > > Index: config/config_default.php > > =================================================================== > > RCS file: /cvsroot/squirrelmail/squirrelmail/config/config_default.php,v > > retrieving revision 1.34 > > diff -u -r1.34 config_default.php > > --- config/config_default.php 2000/10/17 18:15:35 1.34 > > +++ config/config_default.php 2000/12/07 22:35:10 > > @@ -56,6 +56,14 @@ > > // uw > > $imap_server_type = "cyrus"; > > > > +// Rather than going to the signout.php page (which only allows you > > +// to sign back in), setting signout_location allows you to sign > > +// the user out and then redirect to whatever page you want. > > +// For instance, the following would return the user to your > > +// home page: $signout_location = "/"; > > +// Set to the empty string to continue to use the default signout page. > > + $signout_location = ""; > > + > > // Many servers store mail in your home directory. With this, they > > // store them in a subdirectory: mail/ or Mail/, etc. If your > > // server does this, please set this to what the default mail folder > > Index: src/signout.php > > =================================================================== > > RCS file: /cvsroot/squirrelmail/squirrelmail/src/signout.php,v > > retrieving revision 1.20 > > diff -u -r1.20 signout.php > > --- src/signout.php 2000/10/21 16:08:31 1.20 > > +++ src/signout.php 2000/12/07 22:35:10 > > @@ -30,6 +30,12 @@ > > setcookie("key", "", 0, $base_uri); > > setcookie("logged_in", "", 0, $base_uri); > > session_destroy(); > > + > > + if ($signout_location) { > > + header("Status: 303 See Other"); > > + header("Location: $signout_location"); > > + exit; /* we send no content if we're redirecting. */ > > + } > > ?> > > <HTML> > > <HEAD> > > > > > > > > -- > _ > . . Luke Ehresman - "Codito, ergo sum" > / v \ leh...@cs... > /( )\ http://www.css.tayloru.edu/~lehresma > ^^ ^^ > |
From: Lewis B. <lbe...@ab...> - 2000-12-12 22:25:20
|
On Tue, 12 Dec 2000, you wrote: > OK, I'll update the config Perl script (as suggested by Lewis) and > submit it to the Patch Manager for later consideration. > > - Scott Thank you so much, I think this will be well received by all who use sm. -- Lewis Bergman Texas Communications 4309 Maple St. Abilene, TX 79602 915-695-6962 |