From: Daniel W. <d...@ni...> - 2006-07-03 15:38:04
|
Dear Devs, I have a particular message that appears to kill php/imap/squirrelmail. When I click on it it shows the error: Fatal error: Maximum execution time of 30 seconds exceeded in /home/scripts/webmail/squirrelmail-1.4.4-LIVE/functions/mime.php on line 1478 This line in the file is: 1477: $content = preg_replace("|url\s*\(\s*$cidurl\s*\)|si", 1478: "url($httpurl)", $content); I tried commenting out this line but then the error shows: Fatal error: Maximum execution time of 30 seconds exceeded in /home/scripts/webmail/squirrelmail-1.4.4-LIVE/functions/mime.php on line 1474 The relevant code is: > /** > * Fix urls that refer to cid: > */ > while (preg_match("|url\s*\(\s*([\'\"]\s*cid:.*?[\'\"])\s*\)|si", > $content, $matches)){ //**LINE 1474** > $cidurl = $matches{1}; > $httpurl = sq_cid2http($message, $id, $cidurl, $mailbox); > $content = preg_replace("|url\s*\(\s*$cidurl\s*\)|si", > "url($httpurl)", $content); > } This only happens on this particular message. The message, as I understand, was a simple mailing out with part plain text and part html. The comment says something about cid urls. These are the relevant lines in the email with cid in them (formatting is indeed a little strange): > /* Page Definitions */ > @page > {mso-endnote-separator:url("cid:header.htm\@01C69605.46388570") es; > = > mso-endnote-continuation-separator:url("cid:header.htm\@01C69605.46388570= > ") ecs; > = > mso-endnote-continuation-notice:url("cid:header.htm\@01C69605.46388570") = > ecn; > mso-endnote-numbering-style:arabic;} > @page Section1 > {size:595.3pt 841.9pt; > margin:72.0pt 72.0pt 72.0pt 72.0pt;} > div.Section1 > {page:Section1; > mso-endnote-numbering-style:arabic;} Does that give you any clues? I could, if helpful, privately send you a copy of the email body so you can see what might be causing this problem. I'd rather not post the email in public. Best wishes and thanks, Daniel |
From: Daniel W. <d...@ni...> - 2006-07-03 16:10:47
Attachments:
mailsample.txt
|
Further to my post here, attached, is the full email that has been obfuscated using Timo's (author:Dovecot) script. I'm not sure how helpful it will be though!! Dan |
From: Rusty N. <rn...@ri...> - 2006-07-03 16:11:23
|
Daniel, This is the same problem I was reporting and Paul said he was working on. Basically, I have 2 HTML emails that cause squirrelmail to go into an infinite loop and cause a thread to use 100% of the CPU on the server. I sent him the offending message (this was one from expedia, another is from fedex) and haven't heard anything back. Rusty Daniel Watts wrote: > Dear Devs, > > > I have a particular message that appears to kill php/imap/squirrelmail. > > > When I click on it it shows the error: > > > Fatal error: Maximum execution time of 30 seconds exceeded in > /home/scripts/webmail/squirrelmail-1.4.4-LIVE/functions/mime.php on line > 1478 > > > This line in the file is: > > > 1477: $content = preg_replace("|url\s*\(\s*$cidurl\s*\)|si", > 1478: "url($httpurl)", $content); > > > I tried commenting out this line but then the error shows: > > > Fatal error: Maximum execution time of 30 seconds exceeded in > /home/scripts/webmail/squirrelmail-1.4.4-LIVE/functions/mime.php on line > 1474 > > > The relevant code is: > > >> /** >> * Fix urls that refer to cid: >> */ >> while (preg_match("|url\s*\(\s*([\'\"]\s*cid:.*?[\'\"])\s*\)|si", >> $content, $matches)){ //**LINE 1474** >> $cidurl = $matches{1}; >> $httpurl = sq_cid2http($message, $id, $cidurl, $mailbox); >> $content = preg_replace("|url\s*\(\s*$cidurl\s*\)|si", >> "url($httpurl)", $content); >> } >> > > > This only happens on this particular message. > > > The message, as I understand, was a simple mailing out with part plain > text and part html. > > The comment says something about cid urls. These are the relevant lines > in the email with cid in them (formatting is indeed a little strange): > >> /* Page Definitions */ >> @page >> {mso-endnote-separator:url("cid:header.htm\@01C69605.46388570") es; >> = >> mso-endnote-continuation-separator:url("cid:header.htm\@01C69605.4638857 >> 0= >> ") ecs; >> = >> mso-endnote-continuation-notice:url("cid:header.htm\@01C69605.46388570") >> = >> ecn; mso-endnote-numbering-style:arabic;} >> @page Section1 >> {size:595.3pt 841.9pt; >> margin:72.0pt 72.0pt 72.0pt 72.0pt;} >> div.Section1 {page:Section1; >> mso-endnote-numbering-style:arabic;} >> > > Does that give you any clues? > > > I could, if helpful, privately send you a copy of the email body so you > can see what might be causing this problem. I'd rather not post the email > in public. > > Best wishes and thanks, > Daniel > > > > > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job > easier Download IBM WebSphere Application Server v.1.0.1 based on Apache > Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > -- > squirrelmail-devel mailing list Posting Guidelines: > http://www.squirrelmail.org/wiki/MailingListPostingGuidelines > List Address: squ...@li... > List Archives: > http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel > List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139 > List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel > > |
From: Daniel W. <d...@ni...> - 2006-07-03 16:16:20
|
Rusty Nejdl wrote: > Daniel, > > This is the same problem I was reporting and Paul said he was working on. > Basically, I have 2 HTML emails that cause squirrelmail to go into an > infinite loop and cause a thread to use 100% of the CPU on the server. I > sent him the offending message (this was one from expedia, another is from > fedex) and haven't heard anything back. > > Rusty > > Hi Rusty, Glad it's not just me - yes it does seem to be a php code issue rather than the IMAP server itself dying when it tries to read the message. The two messages you have problems open up fine in outlook etc? The message I cannot read in squirrelmail loads fine in Thunderbird. Best wishes, Daniel |
From: Rusty N. <rn...@ri...> - 2006-07-03 18:08:53
|
> Glad it's not just me - yes it does seem to be a php code issue rather > than the IMAP server itself dying when it tries to read the message. The > two messages you have problems open up fine in outlook etc? The message I > cannot read in squirrelmail loads fine in Thunderbird. > > Best wishes, > Daniel > Yes, the emails are viewable in every other client I have tested with. The messages are generally M$ type HTML emails and fortunately, I don't have many examples of them. Rusty |
From: Daniel W <d...@ni...> - 2006-07-04 22:29:14
|
Rusty Nejdl wrote: >> Glad it's not just me - yes it does seem to be a php code issue rather >> than the IMAP server itself dying when it tries to read the message. The >> two messages you have problems open up fine in outlook etc? The message I >> cannot read in squirrelmail loads fine in Thunderbird. >> >> Best wishes, >> Daniel >> > > Yes, the emails are viewable in every other client I have tested with. > The messages are generally M$ type HTML emails and fortunately, I don't > have many examples of them. > > Rusty > Just to let you know, Rusty, that I think they fixed this in 1.4.5! > - Fixed cid handling from Outlook Express client when it doesn't create a > valid content-id to go with CID tag. This resolves #855320, and should > be considered a workaround. The real issues needs resolving by MS. See the changelog. To the Squirrelmail Devs - sorry for bringing up an old issue. We'll be upgrading 1.4.4 -> 1.4.7 shortly! Daniel |
From: Rusty N. <rn...@ri...> - 2006-07-04 22:38:41
|
>> > > Just to let you know, Rusty, that I think they fixed this in 1.4.5! > Daniel, Drat. I am running the CVS 1.5.1 head version and so I had, incorrectly, thought you were reporting the same issue. It seems that this is still an issue as I just cvsup'd and am still able to replicate. Perhaps whatever fixed the problem in 1.4.5 can be applied to the CVS Head version. I don't know right now as I haven't looked at the diff's yet. Rusty |
From: Daniel W <d...@ni...> - 2006-07-04 23:16:26
|
Rusty Nejdl wrote: >> Just to let you know, Rusty, that I think they fixed this in 1.4.5! >> > > Daniel, > > Drat. I am running the CVS 1.5.1 head version and so I had, incorrectly, > thought you were reporting the same issue. It seems that this is still an > issue as I just cvsup'd and am still able to replicate. Perhaps whatever > fixed the problem in 1.4.5 can be applied to the CVS Head version. I > don't know right now as I haven't looked at the diff's yet. > > Rusty No my fault - I should have, as always, posted my SM version! When we move to 1.4.7 I'll report if this problem still occurs. Best wishes, Dan |
From: Daniel W. <d...@ni...> - 2006-07-06 13:19:59
|
Daniel W wrote: > Rusty Nejdl wrote: >>> Just to let you know, Rusty, that I think they fixed this in 1.4.5! >>> >> Daniel, >> >> Drat. I am running the CVS 1.5.1 head version and so I had, incorrectly, >> thought you were reporting the same issue. It seems that this is still an >> issue as I just cvsup'd and am still able to replicate. Perhaps whatever >> fixed the problem in 1.4.5 can be applied to the CVS Head version. I >> don't know right now as I haven't looked at the diff's yet. >> >> Rusty > > No my fault - I should have, as always, posted my SM version! > When we move to 1.4.7 I'll report if this problem still occurs. > > Best wishes, > Dan > As promised: 1.4.7 does NOT have this problem. It shows these emails fine. Of note - the problem ONLY occurs if they user is viewing the email 'as html'. 1.5.1 DOES still have this problem however and the developers should promote the fix in 1.4.7 to the dev branch. Hope this helps, Daniel |
From: Jonathan A. <jo...@sq...> - 2006-07-06 18:47:02
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Daniel, On Thursday, July 06, 2006, Daniel wrote: >>>> Just to let you know, Rusty, that I think they fixed this in 1.4.5! >>> Drat. I am running the CVS 1.5.1 head version and so I had, >>> incorrectly, thought you were reporting the same issue. It seems >>> that this is still an issue as I just cvsup'd and am still able to >>> replicate. Perhaps whatever fixed the problem in 1.4.5 can be >>> applied to the CVS Head version. I don't know right now as I >>> haven't looked at the diff's yet. >> No my fault - I should have, as always, posted my SM version! >> When we move to 1.4.7 I'll report if this problem still occurs. >> >> Best wishes, >> Dan >> > 1.4.7 does NOT have this problem. It shows these emails fine. > Of note - the problem ONLY occurs if they user is viewing the email 'as > html'. > 1.5.1 DOES still have this problem however and the developers should > promote the fix in 1.4.7 to the dev branch. You might want to test 1.5.2-cvs and confirm there. 1.5.1 is very old now, and 1.5.2-cvs is far more advanced. Plus i believe I ported the code to both stable and development branches when I originally fixed this issue. - -- Jonathan Angliss <jo...@sq...> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (MingW32) iD8DBQFErVqHK4PoFPj9H3MRAgdrAKCSenChWSMhRtoGcE+raxWT/g0z/wCfYww2 CX7r01pklR4P4swReeENChU= =jPI0 -----END PGP SIGNATURE----- |
From: Rusty N. <rn...@ri...> - 2006-07-06 20:10:45
|
>> 1.5.1 DOES still have this problem however and the developers should >> promote the fix in 1.4.7 to the dev branch. > > You might want to test 1.5.2-cvs and confirm there. 1.5.1 is very old > now, and 1.5.2-cvs is far more advanced. Plus i believe I ported the code > to both stable and development branches when I originally fixed this > issue. > I have the most recent CVS head. I think I mispoke when I said 1.5.1. I have whatever is the development version. I'm not at home so I cannot say 100% but I'm like 99% certain this is correct. However, I can verify that as of yesterday, I still have emails that will crash squirrelmail. I never got an email from you to test so I could not verify that this was fixed when you submitted your fix. Rusty |