squirrelmail-devel — SquirrelMail Development Mailing List

Re: [SM-DEVEL] What's the release model currently?

[Paul L. <pa...@sq...>]

On Sun, March 21, 2021 2:18 pm, Thorsten Schöning wrote:
> Hi,
>
> I need to host an arbitrary old instance of SquirrelMail originally
> not set up by me at all. Though, I needed to update that host from UB
> 16.04 to 20.04 because I needed a newer PHP and ran into some problems
> with SquirrelMail, e.g. the INBOX simply doesn't show any mails for
> anyone anymore.

Yes, as with most any software, running some old version of SquirrelMail
won't work on newer systems.  There are also potential security
vulnerabilities related to running out-of-date software.

> So, is the linked GitHub-repo some kind of official fork or is it
> "only" an interested user like me?

The latter.  From its byline, I assume it appeared near the time PHP 7 was
released.  At this time, SquirrelMail itself (upstream) is, as far as I am
aware, fully compatible with PHP versions 7 and 8, as long as you use one
of our SVN nightly builds from the downloads page.

> Any reason why you didn't release
> anything for years, even though you seem to have maintained the
> software? Are you going to release in the near future and if so, how
> compatible will 1.4.23 with 1.4.22 and 1.5.2 with whatever pre-dated
> that?

There will eventually be a release for 1.4.23 for certain; and probably
for 1.5.2, but I can't give you a timeline for that at the moment.  Not
sure what you have in mind when asking about compatibility, but there
shouldn't be much headache upgrading from previous versions of 1.4.x to
1.4.23 since that is our STABLE branch.

> I would like to know if it makes more sense to e.g. work with trunk or
> alike directly instead of waiting for releases.

I only recommend using the nightly snapshot releases since they contain
important features and fixes, including some security related matters.

Cheers,
-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

[SM-DEVEL] What's the release model currently?

[<tsc...@am...>]

Hi,

I need to host an arbitrary old instance of SquirrelMail originally
not set up by me at all. Though, I needed to update that host from UB
16.04 to 20.04 because I needed a newer PHP and ran into some problems
with SquirrelMail, e.g. the INBOX simply doesn't show any mails for
anyone anymore. OTOH, sending mails still seems to work. This is most
likely because my version of Squirrel doesn't support the newer PHP
properly, e.g. I get the following error:

```
Kategorie: | PHP
-- | --
Nachricht: | Illegal string offset 'A001'
FILE: | /[...]/squirrelmail/functions/imap_general.php
LINE: | 456
```

During investigation of how to deal with problems like these I had a
look for newer releases, forks etc. of SquirrelMail and came across
the following GIT-repo, which made me aware that there are still
commits UPSTREAM as well.

https://github.com/RealityRipple/squirrelmail

Additionally, while the last official releases are years old, the
download page contains the following newer snapshots currently for
1.4.23 and 1.5.2.

> squirrelmail-20210321_0200-SVN.stable.tar.gz
> squirrelmail-20210321_0200-SVN.devel.tar.bz2

This makes me wonder what the current release process is, what the
linked GIT-repo is and stuff like that. Would be great if you could
explain this a bit to me, so that I know which verion of SquirrelMail
I should migrate to.

So, is the linked GitHub-repo some kind of official fork or is it
"only" an interested user like me? Any reason why you didn't release
anything for years, even though you seem to have maintained the
software? Are you going to release in the near future and if so, how
compatible will 1.4.23 with 1.4.22 and 1.5.2 with whatever pre-dated
that?

I would like to know if it makes more sense to e.g. work with trunk or
alike directly instead of waiting for releases. Am doing that for
other software as well already.

Thanks!

Mit freundlichen Grüßen

Thorsten Schöning

-- 
AM-SoFT IT-Service - Bitstore Hameln GmbH i.G.
Mitglied der Bitstore Gruppe - Ihr Full-Service-Dienstleister für IT und TK

E-Mail: Tho...@AM...
Web:    http://www.AM-SoFT.de/

Tel:   05151-  9468- 0
Tel:   05151-  9468-55
Fax:   05151-  9468-88
Mobil:  0178-8 9468-04

AM-SoFT IT-Service - Bitstore Hameln GmbH i.G., Brandenburger Str. 7c, 31789 Hameln
AG Hannover HRB neu - Geschäftsführer: Janine Galonska


Für Rückfragen stehe ich Ihnen sehr gerne zur Verfügung.

Mit freundlichen Grüßen

Thorsten Schöning


Tel: 05151 9468 0
Fax: 05151 9468 88
Mobil: 
Webseite: https://www.am-soft.de 

AM-Soft IT-Service - Bitstore Hameln GmbH i.G. ist ein Mitglied der Bitstore Gruppe - Ihr Full-Service-Dienstleister für IT und TK

AM-Soft IT-Service - Bitstore Hameln GmbH i.G.
Brandenburger Str. 7c
31789 Hameln
Tel: 05151 9468 0

Bitstore IT-Consulting GmbH
Zentrale - Berlin Lichtenberg
Frankfurter Allee 285
10317 Berlin
Tel: 030 453 087 80

CBS IT-Service - Bitstore Kaulsdorf UG
Tel: 030 453 087 880 1

Büro Dallgow-Döberitz
Tel: 03322 507 020

Büro Kloster Lehnin
Tel: 033207 566 530

PCE IT-Service - Bitstore Darmstadt UG
Darmstadt
Tel: 06151 392 973 0

Büro Neuruppin
Tel: 033932 606 090

ACI EDV Systemhaus Dresden GmbH
Dresden
Tel: 0351 254 410

Das Systemhaus - Bitstore Magdeburg GmbH
Magdeburg
Tel: 0391 636 651 0

Allerdata.IT - Bitstore Wittenberg GmbH
Wittenberg
Tel: 03491 876 735 7

Büro Liebenwalde
Tel: 033054 810 00

HSA - das Büro - Bitstore Altenburg UG
Altenburg
Tel: 0344 784 390 97

Bitstore IT – Consulting GmbH
NL Piesteritz 
Piesteritz
Tel: 03491 644 868 6

Solltec IT-Services - Bitstore Braunschweig UG
Braunschweig
Tel: 0531 206 068 0

MF Computer Service - Bitstore Gütersloh GmbH
Gütersloh
Tel: 05245 920 809 3

Firmensitz: AM-Soft IT-Service - Bitstore Hameln GmbH i.G. , Brandenburger Str. 7c , 31789 Hameln
Geschäftsführer Janine Galonska

Re: [SM-DEVEL] Showing 'View as HTML' button more often

[Paul L. <pa...@sq...>]

On Thu, July 23, 2020 8:14 pm, Alexey Shpakovsky wrote:
> On Thu, July 23, 2020 18:16, Paul Lesniewski wrote:
>>
>> I'm not sure, but SquirrelMail does not have code that fully converts a
>> HTML document into plain text.  In many cases the HTML document can be
>> quite complex and the resulting plaintext may be somewhat unreliable.
>> To
>> be clear, the default is for SM to never show tracking pixels or other
>> unsafe, remote-loaded components in the HTML.
>
> I believe SquirrelMail does have such code - in functions/mime.php, lines
> 399-410 in SquirrelMail version 1.5.2 - yes, it's just 11 lines [1]. From

That code does not convert HTML to plain text. It sanitizes HTML.

> my experience this code runs when I have option "Show HTML Version by
> Default" disabled (so I prefer plaintext), and receive an HTML-only
> message (so a message doesn't have a plaintext part).

Because in that case SquirrelMail has nothing else to work with so it does
the same thing it would do if you got an email with both parts and chose
to view the HTML part.

> In patch ticket number 496 [2] you can find screenshot how this
> HTML-to-text conversion looks like together with my attempt to improve it.
> Note that message shown on screenshot was specifically chosen to look
> especially bad before my changes and especially good with them.
> [2] https://sourceforge.net/p/squirrelmail/patches/496/

It looks bad because you're trying to do something SquirrelMail wasn't
designed to do.

I also get annoyed with companies that can't be bothered to send a plain
text part in their email messages, but I'm fairly certain we don't want to
suddenly add a HTML-to-plaintext conversion based on just a few naive
regular expressions that could create security issues.  The code would
have to be in a branch based on a user preference for forcing HTML parts
into plaintext and the conversion would be best done with an already
proven library (see html2text).

Re: [SM-DEVEL] Showing 'View as HTML' button more often

[Alexey S. <al...@sh...>]

On Thu, July 23, 2020 18:16, Paul Lesniewski wrote:
>
> I'm not sure, but SquirrelMail does not have code that fully converts a
> HTML document into plain text.  In many cases the HTML document can be
> quite complex and the resulting plaintext may be somewhat unreliable.  To
> be clear, the default is for SM to never show tracking pixels or other
> unsafe, remote-loaded components in the HTML.

I believe SquirrelMail does have such code - in functions/mime.php, lines
399-410 in SquirrelMail version 1.5.2 - yes, it's just 11 lines [1]. From
my experience this code runs when I have option "Show HTML Version by
Default" disabled (so I prefer plaintext), and receive an HTML-only
message (so a message doesn't have a plaintext part).

I agree that such conversion can be unreliable, that's why I suggest to
always show the link to view message as rendered HTML.

In patch ticket number 496 [2] you can find screenshot how this
HTML-to-text conversion looks like together with my attempt to improve it.
Note that message shown on screenshot was specifically chosen to look
especially bad before my changes and especially good with them.

Alexey.

[1]
https://sourceforge.net/p/squirrelmail/code/HEAD/tree/trunk/squirrelmail/functions/mime.php#l399

[2] https://sourceforge.net/p/squirrelmail/patches/496/

Re: [SM-DEVEL] Showing 'View as HTML' button more often

[Paul L. <pa...@sq...>]

On Thu, July 23, 2020 10:46 am, Alexey Shpakovsky wrote:
> On Tue, July 21, 2020 03:09, Paul Lesniewski wrote:
>>
>> On Sun, July 19, 2020 11:33 pm, Alexey Shpakovsky via squirrelmail-devel
>> wrote:
>>
>>> Hello SquirrelMail devs,
>>>
>>>
>>> First of all, thanks for all the hard work on this long-standing
>>> project!
>>>
>>> Second, my problem: when reading HTML-only mails, SquirrelMail can
>>> render them both as HTML and in "plaintext converted from HTML by
>>> stripping tags"
>>
>> The plaintext version is not something SquirrelMail creates by
>> sanitizing
>>  the HTML part of an email.  It is used to display the text/plain
>> content
>>  part of messages that have such a part.  The reason your example
>> message
>>  doesn't have that link is because there is no plaintext part in that
>> message.
>>
>> I hope that clarifies things.
>
> Thanks for clarification!
>
> That's indeed what I'm suggesting to add: a link to switch between
> (potentially iframed) "real" HTML view and "sanitised" one. Do you think
> someone but me would be using it?

I'm not sure, but SquirrelMail does not have code that fully converts a
HTML document into plain text.  In many cases the HTML document can be
quite complex and the resulting plaintext may be somewhat unreliable.  To
be clear, the default is for SM to never show tracking pixels or other
unsafe, remote-loaded components in the HTML.

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

Re: [SM-DEVEL] Showing 'View as HTML' button more often

[Alexey S. <al...@sh...>]

On Tue, July 21, 2020 03:09, Paul Lesniewski wrote:
>
> On Sun, July 19, 2020 11:33 pm, Alexey Shpakovsky via squirrelmail-devel
> wrote:
>
>> Hello SquirrelMail devs,
>>
>>
>> First of all, thanks for all the hard work on this long-standing
>> project!
>>
>> Second, my problem: when reading HTML-only mails, SquirrelMail can
>> render them both as HTML and in "plaintext converted from HTML by
>> stripping tags"
>
> The plaintext version is not something SquirrelMail creates by sanitizing
>  the HTML part of an email.  It is used to display the text/plain content
>  part of messages that have such a part.  The reason your example message
>  doesn't have that link is because there is no plaintext part in that
> message.
>
> I hope that clarifies things.

Thanks for clarification!

That's indeed what I'm suggesting to add: a link to switch between
(potentially iframed) "real" HTML view and "sanitised" one. Do you think
someone but me would be using it?

Re: [SM-DEVEL] Showing "View as HTML" button more often

[Paul L. <pa...@sq...>]

On Sun, July 19, 2020 11:33 pm, Alexey Shpakovsky via squirrelmail-devel
wrote:
> Hello SquirrelMail devs,
>
> First of all, thanks for all the hard work on this long-standing project!
>
> Second, my problem: when reading HTML-only mails, SquirrelMail can render
> them both as HTML and in "plaintext converted from HTML by stripping tags"

The plaintext version is not something SquirrelMail creates by sanitizing
the HTML part of an email.  It is used to display the text/plain content
part of messages that have such a part.  The reason your example message
doesn't have that link is because there is no plaintext part in that
message.

I hope that clarifies things.

Cheers,
-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

[SM-DEVEL] Showing "View as HTML" button more often

[Alexey S. <al...@sh...>]

Hello SquirrelMail devs,

First of all, thanks for all the hard work on this long-standing project!

Second, my problem: when reading HTML-only mails, SquirrelMail can render
them both as HTML and in "plaintext converted from HTML by stripping tags"
mode, depending on default preference. That is great, but issue is that
the "View as HTML"/"View as plain text" link to switch between them is not
always there. Sample of HTML email where it's not present is provided at
the end of this message.

I was able to track it down to `true` passed as third argument to
`findDisplayEntity` in read_body.php, line 90 [1]:

    if ($message->findDisplayEntity(array(), array('text/html'), true)) {
        $has_html = true;
    }

In the findDisplayEntity function [2] this argument is called `$strict`
and when set to true it limits what entities it can find.

Hence, my question: Does anyone have any arguments in favour of keeping
this argument as `true`, meaning strict, instead of changing it to more
permissive `false`?

`svn blame` points to the commit [3] titled "Merged View as HTML support
into the SquirrelMail core". Looking at available versions of View as HTML
plugin [4], I see that this `true` appeared between versions 2.7 and 3.2
when migrating from SquirrelMail version 1.2 to 1.4. The only hint I get
from View as HTML plugin is this line in changelogs which appeared long
before this:

> Changed to only show link when there is an alternate part

So maybe the original idea was to show this link only when a message had
both HTML and plaintext versions in order to switch between them.

Can it be changed to show this button always, whenever an HTML part exists?


Example email which doesn't get the "View as HTML/plain text" link:

===============================================
Date: Fri, 17 Jul 2020 04:39:00 -0700 (PDT)
From: AliExpress <sp...@al...>
To: us...@ma...
Subject:  Discounted now: item(s) in your cart!
MIME-Version: 1.0
Content-Type: multipart/mixed;
        boundary="----=_Part_139235128"

------=_Part_139235128
Content-Type: text/html;charset=utf-8
Content-Transfer-Encoding: quoted-printable

this is <b>HTML</b> text!<br>
------=_Part_139235128--
===============================================


Links from the text:

[1]:
https://sourceforge.net/p/squirrelmail/code/HEAD/tree/trunk/squirrelmail/src/read_body.php#l90

[2]:
https://sourceforge.net/p/squirrelmail/code/HEAD/tree/trunk/squirrelmail/class/mime/Message.class.php#l986

[3]: https://sourceforge.net/p/squirrelmail/code/10683

[4]: http://squirrelmail.org/plugin_view.php?id=55


Thanks for consideration,
Aleksei.

Re: [SM-DEVEL] Move button changes page to list of messages instead of next message

[Paul L. <pa...@sq...>]

> Thank you so much for your work on Squirrelmail! And I'll try out the
> 1.4.x version as you suggest.

If you need something like the preview_pane plugin, let me know.

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

Re: [SM-DEVEL] Move button changes page to list of messages instead of next message

[Ian K. <ia...@fs...>]

Paul Lesniewski <pa...@sq...> writes:

> Hi Ian,
>
> On Sat, April 25, 2020 3:15 pm, Ian Kelling wrote:
>> In the svn version,
>
> Be aware, svn has a branch for the stable 1.4.x and development 1.5.x
> versions.  Looks like you are using 1.5.2-svn.  Personally I'm still a fan
> of 1.4.x and 1.4.23-svn has a wider breadth of plugins that can make it do
> anything 1.5.x can and a lot more, even if it's just the roll-over message
> list highlighting.  For the FSF, I'm happy to help out with any tweaking
> or updated plugins you might need.
>
>> when viewing a message, if you click the move or
>> copy button, the page changes to the list of messages. In older versions
>> such as 1.4.13, that button was enabled by the delete_move_next plugin,
>
> It's good you are looking at upgrading, but I'd advise against showing the
> URI of your outdated version, since it has a few published security
> vulnerabilities.

Yes, I realized that after I sent it and made sure it was running the
latest version.

>
>> and when pressing move, the page would change to the next message. That
>> is clearly the way it should work. When using the preview panel, this
>> behavior especially makes no sense because you were already seeing the
>> message list and it just turns the preview panel into blank space.
>
> This is an option from the plugin in 1.4.x that never got migrated.  I
> just added it to 1.5.2-svn so it should appear in the next nightly build. 
> You'll want to go to Options-->Display Preferences-->"Return To Message
> List After Move" and turn that option off (it's on by default).

Thank you so much for your work on Squirrelmail! And I'll try out the
1.4.x version as you suggest.

-- 
Ian Kelling | Senior Systems Administrator, Free Software Foundation
GPG Key: B125 F60B 7B28 7FF6 A2B7  DF8F 170A F0E2 9542 95DF
https://fsf.org | https://gnu.org

Re: [SM-DEVEL] Move button changes page to list of messages instead of next message

[Paul L. <pa...@sq...>]

Hi Ian,

On Sat, April 25, 2020 3:15 pm, Ian Kelling wrote:
> In the svn version,

Be aware, svn has a branch for the stable 1.4.x and development 1.5.x
versions.  Looks like you are using 1.5.2-svn.  Personally I'm still a fan
of 1.4.x and 1.4.23-svn has a wider breadth of plugins that can make it do
anything 1.5.x can and a lot more, even if it's just the roll-over message
list highlighting.  For the FSF, I'm happy to help out with any tweaking
or updated plugins you might need.

> when viewing a message, if you click the move or
> copy button, the page changes to the list of messages. In older versions
> such as 1.4.13, that button was enabled by the delete_move_next plugin,

It's good you are looking at upgrading, but I'd advise against showing the
URI of your outdated version, since it has a few published security
vulnerabilities.

> and when pressing move, the page would change to the next message. That
> is clearly the way it should work. When using the preview panel, this
> behavior especially makes no sense because you were already seeing the
> message list and it just turns the preview panel into blank space.

This is an option from the plugin in 1.4.x that never got migrated.  I
just added it to 1.5.2-svn so it should appear in the next nightly build. 
You'll want to go to Options-->Display Preferences-->"Return To Message
List After Move" and turn that option off (it's on by default).

Cheers,
Paul
-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

[SM-DEVEL] Move button changes page to list of messages instead of next message

[Ian K. <ia...@fs...>]

In the svn version, when viewing a message, if you click the move or
copy button, the page changes to the list of messages. In older versions
such as 1.4.13, that button was enabled by the delete_move_next plugin,
and when pressing move, the page would change to the next message. That
is clearly the way it should work. When using the preview panel, this
behavior especially makes no sense because you were already seeing the
message list and it just turns the preview panel into blank space.

After a quick look into the code, I was able to make a one line change
to the svn version so that the the page does not change at all when
pressing move, which helps workaround the problem so that I can then
press a key to go to the next message. I'm hoping someone here is
familiar with the code and can help identify the root cause and find a
proper fix so it goes to the next message.


Here is a comparison of the post request when clicking move in svn vs
old working 1.4.13:

SVN post:

https://webmail.fsf.org/src/read_body.php?mailbox=INBOX&sort=6&startMessage=1&passed_id=18
form data:	
show_more	"0"
move_id	"19"
targetMailbox	"INBOX.Trash"

Working 1.4.13 post:

https://mail1p.fsf.org/src/right_main.php
form data:
smtoken	"EEZR1hS4cPUh"
mailbox	"INBOX"
msg[0]	"19"
targetMailbox	"INBOX.Trash"
moveButton	"Move"


I figured out that if the post url didn't have any path, or had a path
of "right_main.php", like the old version, it would stop changing the
page, and there was already an example in the code of not passing the
path, so I copied that to make this hacky patch:


Index: read_body.php
===================================================================
--- read_body.php       (revision 14855)
+++ read_body.php       (working copy)
@@ -642,7 +642,7 @@
     if (in_array('\\deleted', $aMailbox['PERMANENTFLAGS'],true)) {
         $delete_url = $base_uri . "src/$where";
         $oTemplate->assign('can_be_deleted', true);
-        $oTemplate->assign('move_delete_form_action', $base_uri.'src/'.$where);
+        $oTemplate->assign('move_delete_form_action', '');
         $oTemplate->assign('delete_form_extra', addHidden('mailbox', $aMailbox['NAME'])."\n" .
                                                 addHidden('msg[0]', $passed_id)."\n" .
                                                 addHidden('startMessage', $startMessage)."\n" );



All the relevant post guideline info:

squirrelmail version:
Last Changed Rev: 14848
Last Changed Date: 2020-03-24 13:38:48 -0400 (Tue, 24 Mar 2020)

plugins:

$plugins[] = 'change_password';
$plugins[] = 'newmail';
$plugins[] = 'sent_subfolders';
$plugins[] = 'calendar';
$plugins[] = 'message_details';
$plugins[] = 'fortune';
$plugins[] = 'squirrelspell';
$plugins[] = 'preview_pane';

php version: 7.2+60ubuntu1
apache version: 2.4.29
OS: trisquel 9 (derivative of ubuntu 18.04)
Browser: abrowser 75 (derivative of firefox 75)

I enabled level 2 debug mode, didnt result in any output in the logs.

Configtest shows no errors.

-- 
Ian Kelling | Senior Systems Administrator, Free Software Foundation
GPG Key: B125 F60B 7B28 7FF6 A2B7  DF8F 170A F0E2 9542 95DF
https://fsf.org | https://gnu.org

Re: [SM-DEVEL] Squirrelmail -- timestamp bug

[<jan...@di...>]

>
>
> On 2019/04/13 3:47, jan...@di... wrote:
>> Hi all,
>>
>> it seems that I have found a little bug.
>>
>> Therefore I've done a recording, see here:
>>
>>     https://www.dipl-ing-kessler.de/tmp/squirrel-mail_bug_1.mp4
>>
>> When creating a new email and saving it as a draft, then every second
>> time
>> you're doing this, the timestamp shown is not plain text, but UNIX time
>> instead.
>>
>> Same when sending emails.
>
> This has been fixed and will show up in our next nightly snapshots, or
> get patches here:
>
> 1.4.23:
> https://sourceforge.net/p/squirrelmail/code/14819/
> 1.5.2:
> https://sourceforge.net/p/squirrelmail/code/14818/
>
> Thanks for letting us know.

Hi Paul,

I've tested both versions and on different platforms (Raspbian, Ubuntu)
and it works perfectly.

Great work -- THANKS!

Best regards,

Markus

Re: [SM-DEVEL] [SM-USERS] Squirrelmail -- timestamp bug

[Paul L. <pdo...@gm...>]

> Besides this, the timestamp shown in received emails seems to be the
> "sent" timestamp and not the timstamp received. So, I recognized this bug
> at all.

Click to sort messages by the received column. Otherwise, use the IMAP
info plugin to look at results of test number 6 and debug your system
from there.

Re: [SM-DEVEL] Squirrelmail -- timestamp bug

[Paul L. <pdo...@gm...>]

On 2019/04/13 3:47, jan...@di... wrote:
> Hi all,
> 
> it seems that I have found a little bug.
> 
> Therefore I've done a recording, see here:
> 
>     https://www.dipl-ing-kessler.de/tmp/squirrel-mail_bug_1.mp4
> 
> When creating a new email and saving it as a draft, then every second time
> you're doing this, the timestamp shown is not plain text, but UNIX time
> instead.
> 
> Same when sending emails.

This has been fixed and will show up in our next nightly snapshots, or
get patches here:

1.4.23:
https://sourceforge.net/p/squirrelmail/code/14819/
1.5.2:
https://sourceforge.net/p/squirrelmail/code/14818/

Thanks for letting us know.

[SM-DEVEL] Squirrelmail -- timestamp bug

[<jan...@di...>]

Hi all,

it seems that I have found a little bug.

Therefore I've done a short recording for demonstration, see here:

    https://www.dipl-ing-kessler.de/tmp/squirrel-mail_bug_1.mp4

When creating a new email and saving it as a draft, then every second time
you're doing this, the timestamp in the header and shown in the draft
window shown is not plain text, but UNIX time instead. Meaning:

You save as draft ==> Timestamp OK / plaintext.
You save as draft ==> Timestamp is UNIX format (seconds after 1970-01-01).
You save as draft ==> Timestamp OK / plaintext.
You save as draft ==> Timestamp is UNIX format (seconds after 1970-01-01).
...

Same when sending emails.

Besides this, the timestamp shown in received emails seems to be the
"sent" timestamp and not the timstamp received. So, I recognized this bug
at all.

It occurs in the stable version, 1.4.23/svn and in the developer version.

System details:
Squirrel-Mail 1.4.23 svn as well as 1.5 developer
php 7.0
Exim 4.90_1
Cyrus 2.5.11

I don't know where to start searching the malfunction.
Can someone please have a look to that? -- Thanks in acvance!

Best regards,

Markus

[SM-DEVEL] Squirrelmail -- timestamp bug

[<jan...@di...>]

Hi all,

it seems that I have found a little bug.

Therefore I've done a recording, see here:

    https://www.dipl-ing-kessler.de/tmp/squirrel-mail_bug_1.mp4

When creating a new email and saving it as a draft, then every second time
you're doing this, the timestamp shown is not plain text, but UNIX time
instead.

Same when sending emails.

Besides this, the timestamp shown in received emails seems to be the
"sent" timestamp and not the timstamp received. So, I recognized this bug
at all.

It occurs in the stable version, 1.4.23/svn and in the developer version.

Can someone please have a look to that? -- Thanks in acvance!

Best regards,

Markus

[SM-DEVEL] Squirrelmail -- timestamp bug

[<jan...@di...>]

Hi all,

it seems that I have found a little bug.

Therefore I've done a recording, see here:

    https://www.dipl-ing-kessler.de/tmp/squirrel-mail_bug_1.mp4

When creating a new email and saving it as a draft, then every second time
you're doing this, the timestamp shown is not plain text, but UNIX time
instead.

Same when sending emails.

Besides this, the timestamp shown in received emails seems to be the
"sent" timestamp and not the timstamp received. So, I recognized this bug
at all.

It occurs in the stable version, 1.4.23/svn and in the developer version.

Can someone please have a look to that? -- Thanks in acvance!

Best regards,

Markus

[SM-DEVEL] unsafe_images_rules plugin fix

[Eric P. <er...@ar...>]

I recently upgraded my php installation and found the unsafe_images_rules
was causing unsafe images to no longer works. Turns out it was using
eregi(), which is deprecated. Simply switched it for preg_match() and now
all seems to work. Here's my patch:

--- functions.php.orig	2018-07-14 11:36:07.648915558 -0700
+++ functions.php	2018-07-14 11:36:36.295868619 -0700
@@ -332,7 +332,7 @@
 function unsafe_image_rules_link_string($str) {
     global $unsafe_image_found_email, $Email_RegExp_Match;

-    while (eregi('(' . $Email_RegExp_Match . ')', $str, $hits)) {
+    while (preg_match('(' . $Email_RegExp_Match . ')', $str, $hits)) {
         $str = substr(strstr($str, $hits[0]), strlen($hits[0]));
         if (! isset($unsafe_image_found_email[$hits[0]])) {
             echo '?address=' .


-Eric

Re: [SM-DEVEL] Placement of buttons above the mail

[Paul L. <pa...@sq...>]

On 2017年12月25日 03:13, Michelle Konzack wrote:
> Hello *,
> 
> currently I am trying 1.5.2-SVN but I am anything else then pleased with it.
> It is now already several years old and the plugins are not more working.

Awesome.

> I assume it has something to do with init.php

I doubt it.

> However, I am co-owner of a BioFarm in Estonia and now anything is covered
> with snow and I can not work here except on my computer. which is hopefully
> free of snow and ice  :-)
> 
> I use 86 plugins (see plugin mailinglist) and I am willing to help you out
> to get things running, but I stoped programming PHP in 2012 so I have go
> back into it...
> 
> OK, the new placement of the buttons is nice and better then in SM 1.4.23
> but the buttons are placed very badly, IF there are to many or because of
> the localisation there are broader as the englisch ones...

I'm not happy with some usability issues such as button placement,
either.  I created an as-of-yet unreleased plugin for 1.4.x that changes
a couple positioning problems, but in 1.5.2, things like that can be
more easily changed by just copying the tempate you are using and
customizing it to your heart's content.  Feel free to share back patches
if you think your changes would be broadly applicable.

> E.g. on the rigth side is the FOLDER_SELECT dropdown box (which become
> broader and broader, hence 280px in my case) and on the right the two
> buttons MOVE and COPY, and on the left side DELETE and UNDELETE.

You need to specify what screen you're looking at.  I guess you're on
the message list screen.

> if the space become to narrow, they wrap on top of each other and it looks
> very ugly and does not realy give the space fee. for buttons placed on the
> most-left side.
> 
> Is there a possibility, to move the two buttons MOVE and COPY above the
> dropdown box?

Yep, should be simple if you edit
templates/default/message_list_controls.tpl (near the bottom).  If you
make such a change, users will not be able to tab out of the folder
drop-down and hit the spacebar or enter key to activate the move button.

> It seems, I have three groups of buttons:
> 
> 1)  Left side
> 
>     FLAG  UNFLAG  READ  UNREAD  EXPUNGE
> 
> 2)  Middle
> 
>     DELETE  UNDELETE
> 
> 3)  Right side
> 
>     FOLDER_SELECT  MOVE  COPY
> 
> First of all, the EXPUNGE should be grouped together with DELETE and
> UNDELETE.
> 
> And then, why not place MOVE, COPY and FOLDER_SELECT in one line in this
> order, so if it become to narrow, the FOLDER_SELECT box would flip under
> the MOVE and COPY buttons?

See above.

> Can someone help me to change the sourcecode for it?

See above.

> I want to try this out on a mail server which is only used by myself.
> 
> OH, one of the most important things are:
> 
> 1) Threated view.  How can I get it back?

IIRC, same configuration as for 1.4.x.  Threaded link is at the end of
the pagination links as long as you've configured support for it.

> 2) Send-folder by recipient.  It is realy annoying if I have to go all
> the time back to the Sent folder to move messages arround.

I don't recall if Per Recipient Sent Folders works with 1.5.2, but I
suspect it might, or if not, it would be not too much work to fix.

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

[SM-DEVEL] Placement of buttons above the mail

[Michelle K. <lin...@ta...>]

Hello *,

currently I am trying 1.5.2-SVN but I am anything else then pleased with it.
It is now already several years old and the plugins are not more working.

I assume it has something to do with init.php

However, I am co-owner of a BioFarm in Estonia and now anything is covered
with snow and I can not work here except on my computer. which is hopefully
free of snow and ice  :-)

I use 86 plugins (see plugin mailinglist) and I am willing to help you out
to get things running, but I stoped programming PHP in 2012 so I have go
back into it...

OK, the new placement of the buttons is nice and better then in SM 1.4.23
but the buttons are placed very badly, IF there are to many or because of
the localisation there are broader as the englisch ones...

E.g. on the rigth side is the FOLDER_SELECT dropdown box (which become
broader and broader, hence 280px in my case) and on the right the two
buttons MOVE and COPY, and on the left side DELETE and UNDELETE.

if the space become to narrow, they wrap on top of each other and it looks
very ugly and does not realy give the space fee. for buttons placed on the
most-left side.

Is there a possibility, to move the two buttons MOVE and COPY above the
dropdown box?

It seems, I have three groups of buttons:

1)  Left side

    FLAG  UNFLAG  READ  UNREAD  EXPUNGE

2)  Middle

    DELETE  UNDELETE

3)  Right side

    FOLDER_SELECT  MOVE  COPY

First of all, the EXPUNGE should be grouped together with DELETE and
UNDELETE.

And then, why not place MOVE, COPY and FOLDER_SELECT in one line in this
order, so if it become to narrow, the FOLDER_SELECT box would flip under
the MOVE and COPY buttons?

Can someone help me to change the sourcecode for it?

I want to try this out on a mail server which is only used by myself.

OH, one of the most important things are:

1) Threated view.  How can I get it back?

2) Send-folder by recipient.  It is realy annoying if I have to go all
the time back to the Sent folder to move messages arround.

Thanks in avance

-- 
Michelle Konzack
00372-54541400

Re: [SM-DEVEL] Thread sorting based on latest child instead of initial mail

[Paul L. <pa...@sq...>]

On Wed, March 29, 2017 6:18 am, Jessie Hernandez wrote:
>>
>>
>> On 2017年03月20日 06:54, Jessie Hernandez wrote:
>>> Hi all,
>>>
>>> When sorting mails in squirrelmail I noticed that when you sort on
>>> threads
>>> squirrelmail sorts the emails based on the intial mail and not the
>>> latest
>>> child. So if I would receive an email on an old thread it will not
>>> appear
>>> on my first page at the top but somewhere on a old page. Is there
>>> something I am doing wrong with the sorting?
>>>
>>> I have enabled sorting on my IMAP server.
>>> I am running on a rasberry pi where I use
>>> postfix
>>> Dovecot version 2.2.13
>>> squirrelmail 1.4.23 [SVN]
>>
>> That's the way IMAP thread sorting works unfortunately.  IIRC, the
>> SORT/THREAD extension defines the THREAD command without any support for
>> the kind of sort you'd like (and I agree, it's not very handy).  You
>> could try asking in the Dovecot mailing list if anyone's found a
>> workaround to have the results of the THREAD command returned sorted by
>> the last, most recent child, but the RFC I believe is fixed to sorting
>> by the "root" (oldest/original) of each thread.  Let me know if you find
>> anything and I'd be glad to take a look at it.
>
> Alright I was afraid of that.
> I seem to have read on the Dovecot list that this sorting is done by the
> mail client [1].

No, that thread post seems to be about two things, the Evolution client
specifically (ignore that part) and IMAP THREAD.  Timo said he had
considered breaking RFC to add an option to make THREAD do what you (and
lots of other people I would guess) want.

> Would it be possible to request such a feature for squirrelMail?
> or should I really check with the Dovecot people and is it a feature I
> need to discuss over there?

It's not a mail client thing.  You should beg Timo on everyone's behalf to
do what he had been pondering at that time many years ago.  Let us know if
you get any movement on it.

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

Re: [SM-DEVEL] Thread sorting based on latest child instead of initial mail

[Jessie H. <squ...@je...>]

>
>
> On 2017年03月20日 06:54, Jessie Hernandez wrote:
>> Hi all,
>>
>> When sorting mails in squirrelmail I noticed that when you sort on
>> threads
>> squirrelmail sorts the emails based on the intial mail and not the
>> latest
>> child. So if I would receive an email on an old thread it will not
>> appear
>> on my first page at the top but somewhere on a old page. Is there
>> something I am doing wrong with the sorting?
>>
>> I have enabled sorting on my IMAP server.
>> I am running on a rasberry pi where I use
>> postfix
>> Dovecot version 2.2.13
>> squirrelmail 1.4.23 [SVN]
>
> That's the way IMAP thread sorting works unfortunately.  IIRC, the
> SORT/THREAD extension defines the THREAD command without any support for
> the kind of sort you'd like (and I agree, it's not very handy).  You
> could try asking in the Dovecot mailing list if anyone's found a
> workaround to have the results of the THREAD command returned sorted by
> the last, most recent child, but the RFC I believe is fixed to sorting
> by the "root" (oldest/original) of each thread.  Let me know if you find
> anything and I'd be glad to take a look at it.

Alright I was afraid of that.
I seem to have read on the Dovecot list that this sorting is done by the
mail client [1].

Would it be possible to request such a feature for squirrelMail?
or should I really check with the Dovecot people and is it a feature I
need to discuss over there?

> --
> Paul Lesniewski
> SquirrelMail Team
> Please support Open Source Software by donating to SquirrelMail!
> http://squirrelmail.org/donate_paul_lesniewski.php
>

[1]: https://www.dovecot.org/list/dovecot/2005-July/077857.html

Re: [SM-DEVEL] Thread sorting based on latest child instead of initial mail

[Paul L. <pa...@sq...>]

On 2017年03月20日 06:54, Jessie Hernandez wrote:
> Hi all,
> 
> When sorting mails in squirrelmail I noticed that when you sort on threads
> squirrelmail sorts the emails based on the intial mail and not the latest
> child. So if I would receive an email on an old thread it will not appear
> on my first page at the top but somewhere on a old page. Is there
> something I am doing wrong with the sorting?
> 
> I have enabled sorting on my IMAP server.
> I am running on a rasberry pi where I use
> postfix
> Dovecot version 2.2.13
> squirrelmail 1.4.23 [SVN]

That's the way IMAP thread sorting works unfortunately.  IIRC, the
SORT/THREAD extension defines the THREAD command without any support for
the kind of sort you'd like (and I agree, it's not very handy).  You
could try asking in the Dovecot mailing list if anyone's found a
workaround to have the results of the THREAD command returned sorted by
the last, most recent child, but the RFC I believe is fixed to sorting
by the "root" (oldest/original) of each thread.  Let me know if you find
anything and I'd be glad to take a look at it.

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

Re: [SM-DEVEL] Seriously Dated Interface

[Paul L. <pa...@sq...>]

>> You're welcome to use your vast experience to contribute a skin for
>> SquirrelMail 1.5.2 where a templating layer was added.
>
> I suspected that my email would be received in a negative spirit.
> That’s really not how it was intended.

Then you could work on your delivery.

> I haven’t taken any serious look into SquirrelMail or its templating
> capabilities. But I don’t really think “templating” is what the
> problem is.

Ah, so an educated opinion, then.

> Its more fundamental than that.
>
> I'm not looking for a cute new "skin". I can't be the only one who
> sees a significant functionally disparity between SquirrelMail and
> Gmail or Outlook.com?
>
> I suspect the response will be “/then use Gmail if I love it so much/”
> but that’s not really the point is it?  The question I am asking is
> does SM *intend* to compete in this space? If not then fine.

You speak as if SM is a company with resources to "compete" and take
guidance from you.  For my part, I've had various sub-projects that
probably achieved some of what you are looking for and could see them
continuing, but you also don't seem to be aware that there are also a
number of people who appreciate SM because it isn't bloated; it's fast
and lean.  Some people have expressed appreciation for the simple and
familiar interface, and even though I agree it's dated and not always
well thought-out, those people shouldn't be ignored either.

> But if
> so then what’s it doing to address the glaring gap?

What are *you* doing beside making your opinion known?  If that's all
you've got, opinion noted.

> This was intended as constructive critique.

I don't see much construction in it.

> Or we can just put our

"our"???

> heads in the sand and pretend everything is OK and that we can’t
> imagine why anyone wouldn’t want to use anything other than Alpine
> anyway (oh, and BTW, I *do* use Alpine too).

Good for you, now everyone knows how 1337 you are.

(I try not to perpetuate the poor way of interacting on FOSS mailing
lists, but it's hard not to do that to emails like yours.  So I'll
apologize but not take any of it back.)

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php