Re: [SM-DEVEL] htmlspecialchars borking non-utf8 encodings

[Alexey S. <al...@sh...>]

Thanks!

Yes, indeed that patch solves my issue.

I can confirm that it applies clearly on top of today's stable version
snapshot (1.4.23-svn), and the issue is gone.

I only wonder why it's not added to SVN :) But it's not a problem for me -
I can just use the patch file.

Also, there is a small typo in the patch file: the
$htmlspecialchars_charsets array has 'koi8-R' with uppercase R, while code
below expects all values in this array to be in lowercase.


And thanks for all your hard work on squirrelmail!

Alexey.



On Thu, May 27, 2021 03:31, Paul Lesniewski wrote:
>
>
> On Wed, May 26, 2021 11:50 pm, Alexey Shpakovsky via squirrelmail-devel
> wrote:
>> Hi SquirrelMail devs,
>>
>> Today investigating a decoding failure on one of spam messages I found
>> an
>> unexpected behaviour of htmlspecialchars function which affects
>> SquirrelMail.
>
> I didn't read your mail in detail, because I believe this issue is solved
> by the patch you can find here:
>
> https://sourceforge.net/p/squirrelmail/bugs/2806/?page=3
>
> Patch for 1.4.x:  quoted_printable_fix-1.4.x-version_3.diff
>
> If not, please make sure you're using the newest 1.4.23-svn snapshot with
> this patch.
>
> Cheers,