Re: [SM-DEVEL] Warnings with today's SVN trunk re: Deliver_IMAP.class.php sending simple test message

[Robert H. <rh...@we...>]

The solution to this warning that was happening on every message sent 
was incredibly trivial.
If someone who has rights to commit this wants to commit it where 
appropriate that would be appreciated.

Regards,
Rob

--- squirrelmail/class/deliver/Deliver_IMAP.class.php.dist 2021-02-05 
14:29:03.000000000 -0500
+++ squirrelmail/class/deliver/Deliver_IMAP.class.php 2021-03-28 
20:14:59.266759084 -0400
@@ -52,7 +52,7 @@
       *
       */
      function send_mail($message, $header, $boundary, $stream=false,
-                       &$raw_length, $folder=NULL) {
+                       &$raw_length=0, $folder=NULL) {

          if (is_null($folder))
              die('Internal error. Cannot pass NULL folder name to 
Deliver_IMAP::send_mail()');

On 2021-03-28 7:38 p.m., Robert Hardy wrote:
> I'm trying to work my way from a packaged version of 1.5.2 SVN 
> 20160723 to get an upgraded packaged version of squirrelmail 1.5.2 SVN 
> 20210328 that will work on Ubuntu 20.04.
>
> I'm getting close but have ran into some new warnings when sending a 
> simple test message to myself I get the following at the bottom of the 
> page:
>
> SquirrelMail notice messages
> Category:     PHP, Delayed
> Message:     Declaration of Deliver_IMAP::send_mail($message, $header, 
> $boundary, $stream, &$raw_length, $folder = NULL) should be compatible 
> with Deliver::send_mail($message, $header, $boundary, $stream = false, 
> &$raw_length = 0, $extra = NULL)
> FILE: /usr/share/squirrelmail/class/deliver/Deliver_IMAP.class.php
> LINE:     0
>