Re: [SM-DEVEL] Showing 'View as HTML' button more often

[Alexey S. <al...@sh...>]

On Thu, July 23, 2020 18:16, Paul Lesniewski wrote:
>
> I'm not sure, but SquirrelMail does not have code that fully converts a
> HTML document into plain text.  In many cases the HTML document can be
> quite complex and the resulting plaintext may be somewhat unreliable.  To
> be clear, the default is for SM to never show tracking pixels or other
> unsafe, remote-loaded components in the HTML.

I believe SquirrelMail does have such code - in functions/mime.php, lines
399-410 in SquirrelMail version 1.5.2 - yes, it's just 11 lines [1]. From
my experience this code runs when I have option "Show HTML Version by
Default" disabled (so I prefer plaintext), and receive an HTML-only
message (so a message doesn't have a plaintext part).

I agree that such conversion can be unreliable, that's why I suggest to
always show the link to view message as rendered HTML.

In patch ticket number 496 [2] you can find screenshot how this
HTML-to-text conversion looks like together with my attempt to improve it.
Note that message shown on screenshot was specifically chosen to look
especially bad before my changes and especially good with them.

Alexey.

[1]
https://sourceforge.net/p/squirrelmail/code/HEAD/tree/trunk/squirrelmail/functions/mime.php#l399

[2] https://sourceforge.net/p/squirrelmail/patches/496/