Re: [SM-imapproxy] crashes in SSL_shutdown

[<ma...@ne...>]

Paul Lesniewski <pa...@sq...> wrote:

> Hmm, I cannot reproduce.  Please keep us informed what you find, if
> anything....

I did not find the activity pattern that triggers it. It happens roughly once
a day.

I tried fixing an unchecked malloc, but it did not help. You can still check
the patch in, since it is a real bug, but not the one that triggers this
crash.

--- src/imapcommon.c.orig       2014-01-23 10:02:24.000000000 +0100
+++ src/imapcommon.c    2014-01-23 10:03:50.000000000 +0100
@@ -675,8 +675,13 @@
      * didn't match.
      * Open a connection to the IMAP server so we can attempt to login 
      */
     Server.conn = ( ICD_Struct * ) malloc( sizeof ( ICD_Struct ) );
+    if (Server.conn == NULL) {
+        syslog( LOG_ERR, "%s: malloc() failed: %s -- Exiting.", __func__,
+                strerror( errno ) );
+        exit( 1 );
+    }
     memset( Server.conn, 0, sizeof ( ICD_Struct ) );
 
     /* As a new connection, the ICD is not 'reused' */
     Server.conn->reused = 0;


-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
ma...@ne...