Re: [SM-PLUGINS] php-5.4.10-1 / custom_from

[Paul L. <pa...@sq...>]

On Fri, Mar 15, 2013 at 7:36 PM, Paul Lesniewski <pa...@sq...> wrote:
> On Fri, Mar 15, 2013 at 4:42 PM, Scott Ruckh <sr...@ge...> wrote:
>> On Wed, Jan 02, 2013 at 09:51:58AM -0800, Paul Lesniewski wrote:
>>> On Wed, Jan 2, 2013 at 7:48 AM, Scott Ruckh <sr...@ge...> wrote:
>>> >>
>>> >> Make sure the user preference setting for it is enabled.
>>> >>
>>> > Thank you for the suggestion.
>>> >
>>> > Allow Arbitrary From Addresses: is "checked" for the user who is testing
>>> > custom_from feature.  Configuration item was unchecked, and rechecked to
>>> > see if it would make any difference.  Making this change did not resolve
>>> > the issue.
>>>
>>> Try reverting your PHP version to confirm that PHP is not the problem,
>>> although, again, it should be triggering errors if this is the case.
>>> This issue seems to be specific to your environment, as no one else
>>> has reported such problems, so you might have to do some debugging in
>>> the code itself.  Do you know PHP?
>>>
>> it looks like this line in function cf_modify_compose_page() is not working --
>>
>> $output = preg_replace('|<select name="identity">(.*?</select>\s*</td>\s*</tr>)|s',
>>                           '<select name="identity" '
>>                           . ($javascript_on ? 'onChange="for (i = 0; i < this.length; i++) { if (this.options[i].selected) { this.form.custom_from.value = this.options[i].text; break; } }"' : '')
>>                           . '>$1<tr>'
>>                           . html_tag('td', '', 'right', $color[4], 'width="10%"')
>>                           // i18n: string below intentionally in SquirrelMail domain
>>                           . _("From:") . '</td>'
>>                           . html_tag('td', '', 'left', $color[4], 'width="90%"')
>>                           . substr(addInput('custom_from', $custom_from, 60), 0, -3)
>>                           . ($javascript_on ? ' onfocus="alreadyFocused=true;" ' : '')
>>                           . ' /><br /></td></tr>',
>>                           $output);
>>
>> The variable $output is the same (at least display wise) before and after this statement.  I added an 'echo $output' right before this line, leaving the 'echo $output' that is directly after this
>> line.  On the webpage I end up with two identical outputs where the custom_from field is not present.
>>
>> I do not know enough about PHP or the command being executed to troubleshoot the issue.  I was hoping you might be able to offer some tips on things to try in order to help troubleshoot.
>>
>
> Thanks for your help.  The user in question apparently does not have
> multiple identities set up.  This is where the problem is.  I am
> sending you a fixed plugin package offlist.  Please let me know if it
> fixes the issue so I can issue a general release.

Fix confirmed offlist.

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php