Re: [SM-PLUGINS] Re: Show Username and IP makes logout fail with 1.4.4

[Fredrik J. <sqm...@fi...>]

Hi Kerem.

>> It would be better to have the strings "Your last connection was from"
>> and "on" merged into "Your last connection was from %s on %s" (using
>> sprintf) since that provides translators with more flexibility. Not al=
l
>> languages have the same syntax.
>
> I am doing that right now. You are absolutely right, this should be
> much better for translations. Also with a feedback from Brett Moss, I
> thought about changing "INFO:" to "Welcome," what do you (and folks on =
the
> list) think about it? Maybe that should be a configurable option.

Such an option shold be configured by the administrator if we want to kee=
p
it an i18n string. Since no other config is done for this plugin I vote
"no". And letting the end user config it per account seems like overkill.

A welcome is always nice, but if you choose to have a "Welcome, %s."
string, the %s should be replaced with the full name (for the main
account, not the aliases) and not the account name. It's a more personal
touch. Compare "Welcome, John Doe." and "Welcome, jo...@ex....".

>> You might want to use XHTML 1.0 instead of an older version of HTML.
>
> I actually don't know XHTML. Is there any advantages it will bring to
> such a simple plugin?

Not really, it's just an updated version of HTML. Parts of SquirrelMail i=
s
already XHTLM 1.0 compatible. If you want I can provide a patch off list.

>> New features:
>>
>> DNS lookup for IP address. I added it to the old version, and it only
>> shows when the lookup returns a valid result.
>
> I did not understand this part. Did you incorporate it to 2.2.3? Was it
> for self usage only? I can surely add it to 3.0 and make a configuratio=
n
> option so, the user can choose whether to show her IP address or hostna=
me
> on the left pane.

I never sent it to you or any mailing list. It was just for personal use.
If you want to review it I can send it to you off list (if I still have
it). I don't remember if I coded it properly or coded a quick and dirty
hack.

Sincerely,
Fredrik.