From: Erin S. <ebu...@sq...> - 2003-12-05 16:38:53
|
Jimmy Conner said: > Just to clarify a little something here. The function in question is > currently called noframes_bottom (soon to be DisplayPageFooter), which > all plugins who call DisplayPageHeader will need to call when they end > their page (for closing the tables, outputting the folder list if its o= n > the right, ect...) instead of just outputting a </body></head>. This > function should NOT go in the compatibility plugin as its not only the > plugins that need this function, it is every page in SM that first call= s > DisplayPageHeader and then dies out to a closing html tags. If you > stick this function in the Compat plugin, then according to what was > said earlier, that the compat plugin would not be in Devel versions of > the code (because its not needed) then that function would be lost to > the rest of the codebase that still needs it. Jimmy - the function would go in the compat plugin ONLY for backlevel versions of SM that don't provide it. And yes, to clarify we aren't talking about putting the noframes crap in the compat plugin, we're talking about how to cover the addition of functions that plugins need to use across OLDER versions of SM. So Jimmy - the compat plugin WOULD provide an implementation of displayPageFooter - but that function would ONLY be supplied to versions of SM that DON'T already have the function defined - which is to say, whe= n we add noframes support to devel CVS, it will have an implementation of displayPageFooter in the right place, so it won't need or use what's in the compatibility plugin (they won't even see it, in fact). > > Anyways, just thought I would clear that up, > Jimmy |