#16 mail_fetch plugin should cope with renamed folder

closed-fixed
None
5
2005-04-24
2002-07-21
Anonymous
No

when fetching mail i have this error :

Login OK: Inbox contains [1] messages
Fetching UIDL...
Leaving Mail on Server...
Fetching message 1
A31 NO Invalid mailbox Error Appending Message!

Discussion

  • Tomas Kuliavas

    Tomas Kuliavas - 2004-01-04

    Logged In: YES
    user_id=225877

    No patch available.

    Bug can be reproduced by setting mail_fetch plugin to store
    messages in some folder and then renaming that folder.

     
  • Thijs Kinkhorst

    Thijs Kinkhorst - 2005-04-06
    • assigned_to: nobody --> kink
    • summary: A31 NO Invalid mailbox Error Appending M --> mail_fetch plugin should cope with renamed folder
     
  • Thijs Kinkhorst

    Thijs Kinkhorst - 2005-04-06

    Logged In: YES
    user_id=285765

    The mail_fetch plugin should utilize the
    folder_rename_delete hook then to cope with that, just like
    filters does

     
  • Jonathan Angliss

    Logged In: YES
    user_id=620333

    As I do not use the mail_fetch plugin, I was not able to
    test the fix I have attached. Thijs/Tomas, are you guys
    able to test? It's very simple, it updates the folder name
    to the new name on rename, or sets it to INBOX on delete.

     
  • Tomas Kuliavas

    Tomas Kuliavas - 2005-04-11

    Logged In: YES
    user_id=225877

    patch fixes only one part of the problem. It assumes that
    folder is renamed/deleted inside squirrelmail. we must add
    extra tests.

    Attached mail_fetch2.diff, that also checks if folder was
    renamed/deleted not in squirrelmail and that folder is not
    \noselect.

    Patch also fixes incorrect variable assignment in fetch.php
    $mailfetch_subfolder == 'INBOX';

     
  • Tomas Kuliavas

    Tomas Kuliavas - 2005-04-11

    Second diff for test fix

     
    Attachments
  • Jonathan Angliss

    Logged In: YES
    user_id=620333

    Hehe, glad you looked over the code, that "typo" has
    probably been in there for a bit.

    I completely forgot about external sources affecting the
    folder tree as well, good catch. Is it really necessary
    that the folder be subscribed before the mail can be
    delivered to that folder? Mail should be movable to an
    unsubscribed folder, shouldn't it?

     
  • Tomas Kuliavas

    Tomas Kuliavas - 2005-04-11

    Logged In: YES
    user_id=225877

    replace sqimap_mailbox_is_subscribed() with
    sqimap_mailbox_exists() and be prepared for "I see that
    emails are fetched, but I don't see them in squirrelmail.
    Please help, I lost all my emails." :)

    I think fetching only to subscribed folder is safer and I
    haven't tested appending to unsubscribed mailbox.

     
  • Jonathan Angliss

    Logged In: YES
    user_id=620333

    That's a viable comment... but there might be cases where
    you want to deliver mail to a "hidden" folder for review
    later... Like if you fetch POP3 mail from an account you
    know gets a lot of spam. I'd be more inclined to deliver it
    to a folder I don't see, and handle it every few days or so,
    that way it's not checked for notifications, and such. But
    that might just be me :)

    But I agree, if you'd prefer to send to a subscribed folder,
    that works okay.

     
  • Tomas Kuliavas

    Tomas Kuliavas - 2005-04-11

    Logged In: YES
    user_id=225877

    I think you can't configure plugin to use unsubscribed
    mailbox. It is not listed in folder listing.

    We can make it configuration option.

    mail_fetch_allow_unsubscribed=false/true

     
  • Tomas Kuliavas

    Tomas Kuliavas - 2005-04-18

    Allow use of unsubscribed mailboxes in case admin wants it.

     
    Attachments
  • Tomas Kuliavas

    Tomas Kuliavas - 2005-04-18

    Logged In: YES
    user_id=225877

    Issue should be fixed in 1.5.1cvs.

     
  • Thijs Kinkhorst

    Thijs Kinkhorst - 2005-04-19
    • assigned_to: kink --> nobody
     
  • Jonathan Angliss

    Logged In: YES
    user_id=620333

    Tomas, is there much work in porting this back to stable?

     
  • Tomas Kuliavas

    Tomas Kuliavas - 2005-04-19
    • assigned_to: nobody --> tokul
     
  • Tomas Kuliavas

    Tomas Kuliavas - 2005-04-19

    Logged In: YES
    user_id=225877

    will try porting it to stable by Sunday.

     
  • Tomas Kuliavas

    Tomas Kuliavas - 2005-04-24

    Logged In: YES
    user_id=225877

    Fixed in

    plugins/mail_fetch/fetch.php v.1.19.2.13
    plugins/mail_fetch/functions.php v.1.5.2.3
    plugins/mail_fetch/setup.php v.1.15.2.7

     
  • Tomas Kuliavas

    Tomas Kuliavas - 2005-04-24
    • status: open --> closed-fixed
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks