#2744 SM v1.5.2SVN - newmail plugin

[J. Edner]

Hello,
I identified a problem in the source code of the newmail plugin which is delivered with SquirrelMail v1.5.2 (squirrelmail-20101201_0200-SVN.devel.tar.bz2)
as I tried to translate all strings. By applying a minimal change to the PHP code of the plugin I was able to fix the problem.Please check the patch file for further details.

Regards Juergen

[J. Edner]

patch of file newmail_opt.php

[Paul Lesniewski]

Please explain the problem. I cannot see any problem with the way this was. Thanks very much for contributing.

[J. Edner]

Hello Paul,
line 44 ist currently handled differently compared to the other text strings in line 45, 48, 52 etc. where referred text strings are kept separately. By applying the patch, the code handles the already translated and reffered to text string "Enable Unread Message Notification" in the same way as the following lines do. Additionally it makes translation easier because the existing translation for that text is being used and you can get rid of the double quotes in the string.
I came accross this problem as I tested SM v1.5.2SVN with german language files enabled. I found big gaps in the german translation so I decided to rework the files. Not all text strings had already been added to the default file squirrelmail.po and therefore I had to search the code for matching strings. I've already sent the updated translation to Ralf Hildebrandt so that it can be used to update the existing translation.

Regards
Juergen

[Paul Lesniewski]

Ah, as long as the other lines in that file use the same style, this is good. Accepted. Thanks.