#2699 forward as attachment has no subject

closed-fixed
Compose (426)
6
2010-06-21
2010-01-21
David Stoll
No

When normally forwarding, the subject is filled out. When forwarding as attachment, the subject is blank, so you have to re-type it. However, if it isn't exact, then other e-mail programs don't think it is part of the "conversation" and looks like a completely new and unlinked message.

I would suggest that auto filling the subject be automatic or at least an option that could be set by the user.

Thanks!

Discussion

  • David Stoll

    David Stoll - 2010-06-21

    I have used many versions of squirrelmail, but I believe this bug (or lack of feature) has never been there.

    I hope someone can let me know if it is something that will be worked on or not.
    Basically, it should fill in a "FWD: xxxxxxxx" similar to when you reply, it adds an "RE: xxxxxxxxxxx".

    Thanks!

     
  • David Stoll

    David Stoll - 2010-06-21
    • assigned_to: nobody --> jangliss
    • priority: 5 --> 6
     
  • David Stoll

    David Stoll - 2010-06-21

    Forward as attachment is what I'm talking about...not just regular forward.

    Sorry if that was confusing.

     
  • Paul Lesniewski

    Paul Lesniewski - 2010-06-21
    • assigned_to: jangliss --> pdontthink
    • status: open --> pending-fixed
     
  • Paul Lesniewski

    Paul Lesniewski - 2010-06-21

    This "feature" was never implemented because the architecture of forward-as-attach is completely different than normal forwards. It's a little annoying to hear comments about "bugs" and whatnot, but anyhow.... The attached patch implements this feature for me. Your testing would be appreciated.

     
  • Paul Lesniewski

    Paul Lesniewski - 2010-06-21

    src/compose.php patch line numbers might be slightly off because I'm working with 1.4.21SVN with some unpublished patches, but if it doesn't go in automatically, doing the changes by hand by inspecting the patch should be quite straight forward.

     
  • David Stoll

    David Stoll - 2010-06-21

    Thanks for the info. I didn't mean to say there was definitely a bug. That's why I said "or lack of feature". I'm sure forward as attachment is completely different, but it's only a suggestion as a permanent feature because with most other programs, when you forward as attachment, the subject is filled out. So, will this patch break every time SquirrelMail is updated?

     
  • Paul Lesniewski

    Paul Lesniewski - 2010-06-21

    The patch is meant to be included in the next version if I can get some positive feedback on it. I appreciate your understanding. I just noticed that I missed/forgot the fact that there is also a "forward as attachment" link on the view message screen, so I will create an updated patch that fixes that, too in just a few minutes.

     
  • Paul Lesniewski

    Paul Lesniewski - 2010-06-21

    New fix is uploaded (old one removed)

     
  • David Stoll

    David Stoll - 2010-06-21

    I will ask my mail server guru to update and will be more than happy to comment.

    Thank you so much!

     
  • David Stoll

    David Stoll - 2010-06-21
    • status: pending-fixed --> open-fixed
     
  • Paul Lesniewski

    Paul Lesniewski - 2010-06-21
    • status: open-fixed --> pending-fixed
     
  • David Stoll

    David Stoll - 2010-06-21
    • status: pending-fixed --> open-fixed
     
  • David Stoll

    David Stoll - 2010-06-21

    pdontthink,
    thanks for the patch. I had it implemented and, as far as I can tell, eveything is ok. I noticed that it also had do do with "moving" messages, so I also did a little of that too. Everything seems ok at this point.

    Most importantly, the "forward as attachment" subject now looks like a normal forwarded message's subject.

    Cool!

    We'll be sure to let you know if anything goes haywire.

    When (or in what version) will this be implemented?

    Thanks again,
    David

    Sorry for posting a duplicate, I had totally forgotten I did it. I knew I had intended to make a posting, but just forgot.

     
  • Paul Lesniewski

    Paul Lesniewski - 2010-06-21
    • status: open-fixed --> closed-fixed
     
  • Paul Lesniewski

    Paul Lesniewski - 2010-06-21

    Thanks for the feedback. This will be in the 1.4.21 release, which should be out in the next week or two.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks