#2480 ignores if Encrypt passwords is unchecked

closed-fixed
nobody
5
2007-06-25
2007-06-15
No

I am using 1.4.10a
Mail Fetch -- Version 1.3.0

When a user enters a password, it will always get encrypted regardless if the checkbox is selected or not.

Good code:
if( $mailfetch_cypher == 'on' ) $mailfetch_pass_[$i] = decrypt( $mailfetch_pass_[$i] );

Bad line of code:
setPref($data_dir,$username,"mailfetch_pass_$mf_sn",(isset($mf_pass)?encrypt( $mf_pass ) :""));

Could be:
if( $mailfetch_cypher == 'on' ) setPref($data_dir,$username,"mailfetch_pass_$mf_sn",(isset($mf_pass)?encrypt( $mf_pass ) :""));

Discussion

  • Thijs Kinkhorst

    Thijs Kinkhorst - 2007-06-25

    Logged In: YES
    user_id=285765
    Originator: NO

    Fixed, thanks!

     
  • Thijs Kinkhorst

    Thijs Kinkhorst - 2007-06-25
    • status: open --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks