#1694 entities in translated string when using addSubmit()

I18n
closed-fixed
nobody
5
2005-01-03
2005-01-03
Anonymous
No

I'm ioe-lkml@axxeo.de

Hi there,

first I would like to thank you for this great product.
I use Version 1.4.3a quite regularly.

Bug is as follows:

Switch to German translation. (Translation itself is ok!)
Now klick the "Adressen" link in the upper menu area.
Look at the button "Add address", which is
"Adressen hinzufügen" in German instead of
"Adressen hinzufügen".

The abook_take-plugin doesn't expose this problem, because
it doesn't use addSubmit to make the submit button, but
codes this directly. addSubmit calls addInputField, which
calls htmlspecialchars(), which is wrong in this case.

I see two solutions here:

short term solution:
open coding the input tag (which is what
I've done and I attach a patch for).

long term solution:
do the htmlspecialchars in the USER of
these functions, since only they know exactly,
whether a
string needs
to be converted or not.

Hope that helps, since it is my first contribution to
squirrelmail.

BTW: Is your devel mailing list open or closed?

Regards

Ingo Oeser

Discussion

  • Jonathan Angliss

    Logged In: YES
    user_id=620333

    Have you tested this issue against 1.4.4-RC1? Does it still
    exist?

     
  • Tomas Kuliavas

    Tomas Kuliavas - 2005-01-03
    • milestone: --> I18n
    • status: open --> closed-fixed
     

Log in to post a comment.