#1616 Addressbook: i18n'ed form buttons double-html-encoded

I18n
closed-fixed
5
2004-08-04
2004-07-07
No

Hi,

I'm using Squirrelmail 1.4.3a (PHP 4.3.7 on FreeBSD
with Apache 2.0.50) and when having selected "German"
as a language and I go to the addressbook, the "edit
selected" and "delete selected" buttons, which in their
German translation normaly are labeled "Bearbeite
markierte Einträge" and "Ausgewählte Einträge löschen"
are labeled like "Bearbeite markierte Eintr&amul;ge".
This means that the conversion from ä-> ä is
somehow done twice and the "&" from the html-encoded
umlaut is translated into the ampersand-code.

How can this be fixed ?
I tried to change the squirrelmail.po-file, but that
didn't change anything.

List of plugins installed (if that is interesting):
Plugins
Installed Plugins
1. fortune
2. squirrelspell
3. abook_take
4. delete_move_next
5. message_details
6. sent_subfolders
7. mail_fetch
8. newmail
9. sasql
10. abook_import_export
11. askuserinfo
12. compatibility
13. empty_folders
14. vkeyboard
15. address_add

Available Plugins:
16. translate
17. spamcop
18. filters
19. calendar
20. listcommands
21. administrator
22. info
23. bug_report
24. addgraphics
25. disk_quota

Rainer

Discussion

  • Andreas Schubert

    Logged In: YES
    user_id=440010

    Hi,

    had this problem too. The cause for this behavior is the new
    function
    "addInputField" in the new forms.php (in directory
    functions). It uses
    the htmlspecialchars function of php. With this, you can
    transform
    characters like "&" to "&".
    Problem with the german locales: they contain lot's of
    "Umlaute" like
    "ä" or "ö". htmlspecialchars transforms them to
    "ä" or "ö" and so on...
    Fast fix could be to replace all "&*uml;" and the "ß" in
    locale/de_DE/LC_MESSAGES/squirrelmail.po with the corresponding
    german "Umlauts".

    Andreas

     
  • Rainer Duffner

    Rainer Duffner - 2004-07-09

    Logged In: YES
    user_id=845607

    Did this work for you ?
    I can change that file (and it is re-read, I can see that
    because the Umlauts in the rest of squirrelmail are not
    longer encoded) - but it changes nothing for the addressbook.

    Or am I making some silly mistake ?

    Thanks,
    Rainer

     
  • Rainer Duffner

    Rainer Duffner - 2004-07-09

    Logged In: YES
    user_id=845607

    Please provide more detail about your IMAP server, operating
    system, Version of SquirrelMail, and the circumstances which
    produced the bug.

    Since we could not reproduce this problem, providing the same
    information will not help. Please be as specific as possible.
    Some problems may require taht we make a coding effort and then
    you try the new version to see the results. Thanks for your help.

     
  • Andreas Schubert

    Logged In: YES
    user_id=440010

    Hi rainer_d,

    it worked for me...and i don't see why this should not work
    for you... :-/ Are you sure, that you changed all? Or just
    try to change the text of one of the adressbook-buttons to
    see if this works...

    I'm using SquirrelMail 1.4.3a on OpenBSD 3.5 with apache
    1.3.29 and PHP 4.3.6.

    Hope this helps,

    Andreas

     
  • Rainer Duffner

    Rainer Duffner - 2004-07-09

    Logged In: YES
    user_id=845607

    Hm, now that you say it...
    I've changed the "" in the
    /usr/local/www/squirrelmail/locale/de_DE/LC_MESSAGES/squirrelmail.po
    file to "ae" and ran msgfmt -o squirrelmail.mo
    squirrelmail.po - but it still showed the wrong double-encoding.
    Why would it do that ?

    Rainer

     
  • Andreas Schubert

    Logged In: YES
    user_id=440010

    Rainer,

    sorry, i don't know why it's doing it. Probably a wired
    caching thing?

    Ever tried to restart everything? I know, that's the windows
    way, but sometimes it really helps... ;-)

    Regards Andreas

     
  • Rainer Duffner

    Rainer Duffner - 2004-07-09

    Logged In: YES
    user_id=845607

    Hello,

    Your report was filed against an old version of SquirrelMail. We
    have new releases out which have fixed many issues. Can you
    please test the most recent version - or even better the CVS
    version - and report if this issue still exists? Thanks!

     
  • Rainer Duffner

    Rainer Duffner - 2004-07-09

    Logged In: YES
    user_id=845607

    OK, that was really weird.
    I need to stop and start apache (almost) each time I change
    something in those files.

    But I still do not consider this a "solution".
    Or is it planned to be able to use Umlauts in the .po-files
    sitewide and have them translated by squirrelmail ?

    Thanks for your help !

    Rainer

     
  • Andreas Schubert

    Logged In: YES
    user_id=440010

    Hi,

    i've just tested that issue against the CVS version of
    squirrelmail and this one doesn't have problems with german
    "Umlaute". But i don't agree with you, that 1.4.3a is an old
    version of squirrelmail. It's the latest stable release (so
    it's said on the website). And on a production system I
    won't use a development or CVS version of a product. Perhaps
    someone could fix the stable version, too?

    Kind regards, Andreas

     
  • Andreas Schubert

    Logged In: YES
    user_id=440010

    Hi,

    another comment: in Version 1.4.2, addressbook.php inserted
    buttons like the "Delete selected" directly (via some echo
    '<INPUT TYPE...'). In 1.4.3a it is done via this
    "addSubmit" function that calls "htmlspecialchars", in the
    current CVS it's again the "1.4.2"-Style.
    It looks like the 1.4.3a trunk has developed further than
    1.5 to me. And if the 1.5 adds these changes, there will
    this problem be back (i just tested it by inserting one
    "addSubmit" to the addressbook.php) because
    "functions/forms.php" isn't different from 1.4.3a to 1.5.

    So please, have a look at this... :-)

    Bye,

    Andreas

     
  • Tomas Kuliavas

    Tomas Kuliavas - 2004-07-11

    Logged In: YES
    user_id=225877

    You need to fix translation
    (replace latin1 htmlentities in
    locale/de_DE/LC_MESSAGES/squirrelmail.po with normal 8bit
    symbols). If you have recode support in your system, command
    'recode -d html..iso8859-1 squirrelmail.po' should do the trick.

    Then you have to recompile translation
    (msgfmt -v -c -o squirrelmail.mo squirrelmail.po).

    Then you have to restart your webserver. PHP gettext
    translations are cached and in some configs modified files
    are not used until browser is restarted.

    I think you can reproduce this problem in 1.5.1cvs and
    1.4.4cvs versions, because they use similar code and both
    versions should use same translation. If you can't reproduce
    problem on cvs version - you are using modified translation.

    Information about this bug will be forwarded to German
    translator. Fixed translation will be released in next
    locales package for 1.4.3.

     
  • Tomas Kuliavas

    Tomas Kuliavas - 2004-07-11
    • assigned_to: nobody --> tokul
     
  • Tomas Kuliavas

    Tomas Kuliavas - 2004-08-04
    • status: open --> closed-fixed
     

Log in to post a comment.