About item under Application name to work
A Java SQL client for any JDBC compliant database
Brought to you by:
colbell,
gerdwagner
Menu
▾
▴
1 Attachments
#598 About item under Application name to work
A small patch to make the "About" item under Application name to work is attached.
Does require Java 9 or newer.
(I also have some changes to make squirrelsql compile with Java 11 if you're interested, all in AutoCorrectController, compiles but not really tested)
I completely forgot; it is was macos.
I guess it would be pretty much the same as:
part of merge-request #57. There I also suggest multi-release JAR packaging compatible with Java8/9+, but Gerd is not convinced so far.
As you're on Mac, I guess/hope you're using a retina display and I wonder if you're interested and you could give a try of merge-request #57?
Last edit: Stanimir Stamenkov 2021-02-15
I could probably could do that.
May need a little help here, how do I fetch the merge-request from commandline git?
It will be a few days before I can do more with this.
You could clone my fork directly:
git clone https://git.code.sf.net/u/stanio/squirrel-sqlor you could add it as a remote to existing clone:
git remote add -f stanio https://git.code.sf.net/u/stanio/squirrel-sqlIn both cases:
git checkout multires-iconsthen
cd sql12and build usingant. You could try running directly from the working copy usingant runApp, or you could perform install from theoutput/izPackInstallJars.Hi,
tried that and the application runs.
What should I look for here to be sure I get useful results?
Hi Heklaz. Thank you for trying it out! I'm interest to find out if you're seeing any improvement (none, somewhat, significant) in the quality of the icons, working on a hidpi/retina screen. I guess it is better to continue this exchange over in merge-request #57.
ok, will do that
Hi Stanimir,
I’ve tried to compare your multi-res version with the standard.
It is a bit sharper I think. At standard size it is not a big difference but comparing screenshots show the difference.
See the attached where the top bar at magnification is a lot sharper.
Regards
jørgen nørgaard
e-mail: jnp@anneli.dk
tlf: 2627 3769
Related
Feature Requests: #598
Thank you for the feedback, Heklaz. This generally sustains my evaluation more significant improvement is seen with non-integral scaling-factor screens like 1.75x, 1.5x, 1.25x, and non-Macs (such as Windows):
(from the initial merge-request #50)
I'm able to reproduce your problem: When SQuirreL is installed on a Mac using the the Mac Installer one can't open the SQuirreL's About message box.
I also see that your patch works. But I'm sorry SQuirreL is still based in Java 1.8 and I don't consider the feature relevant enough to switch to Java 11.
As a workaround you may use the standard installer. This will make the About box available although for the cost of loosing some Mac integration features.
Gerd
Just committed a fix which ensures that all menus are available on Mac OS. The fix will be available in future snapshots and versions.
Hi,
sounds good. I'll check that later.
Hi Gerd,
I’ve tried the build for 1/3 and it does seem to me that the About under the application menu still doesn’t show SQuirreLSQL’s About menu.
And one question.
The application menu (SQuirreLSQL) has an exit command, ⌘-Q, that does not exit the same way as ctrl-Q. Is that something you can make work. My patch will require at least java 9.
Regards
jørgen nørgaard
e-mail: jnp@anneli.dk
tlf: 2627 3769
Related
Feature Requests: #598
I agree it doesn't show under the menu named "SQuirreLSQL". But its available under the "Help" menu. I think that's not perfect but rather alright.
I noticed the exit command, ⌘-Q problem, too. This one I consider quite severe because it passes saving preferences on close. By now I think that after the 4.2.0 release we should switch to Java 11 and make some use of the desktop integration features.
Hi,
Nice, I’ll follow that.
--
jørgen nørgaard
e-mail: jnp@anneli.dk
tlf: 2627 3769
Related
Feature Requests: #598
The new snapshot
https://sourceforge.net/projects/squirrel-sql/files/3-snapshots/snapshot-20210411_2107/
requires Java 11 and makes Apple's application close command "Command key"+Q work the same way Ctrl+Q does. It also properly supports the Apple specific About-Command.