SourceForge has been redesigned. Learn more.
Close

#363 Cancel should cancel close session too

2.2rc1
closed-fixed
Unknown (89)
5
2006-04-07
2006-03-22
eagle79
No

When closing a session, you are asked if you want to
save the editor contents. If you say yes, and then
choose cancel, the save dialog cancels and the session
closes. i.e.

1. Close (asked if I want to save)
2. Yes
3. Cancel
4. Session closes

In my opinion, clicking cancel here should not only
cancel the save dialog, but cancel the session close
operation as well.

1. Close (asked if I want to save)
2. Yes
3. Cancel
4. Session remains open

Discussion

  • Rob Manning

    Rob Manning - 2006-03-22

    Logged In: YES
    user_id=1287991

    OK, but I'm not sure I follow the sequence. Here is
    what I see (assumes "Confirm Session Close" is checked)

    1. Open a session
    2. Open a file in the SQL editor.
    3. Make a change to the contents of the SQL editor.
    4. Click the "close" button on the session window (x)
    5. Dialog appears "Are you sure you want to close the session"
    6. Click "No" - dialog goes away, and no prompt to save editor
    contents. The editor still has the changes.
    7. Click the "close" button on the session window (x)
    8. Dialog appears "Are you sure you want to close the session"
    9. Click the "Yes" dialog - dialog goes away and a new
    dialog appears asking if you want to save the editor contents.
    10. Click "No" and the changes are discarded. Click "Yes"
    and the changes are applied.

    This flow seems reasonable to me. Which step(s) above are a
    problem, and why? Or did I miss your flow completely?

    Rob

     
  • eagle79

    eagle79 - 2006-03-23

    Logged In: YES
    user_id=1300245

    Starting with step 10, click yes and the file name dialog
    comes up (assuming a new file). You change your mind
    (perhaps you forgot to put your USB drive in) and click
    cancel in the filename dialog. The save cancels, but the
    session closes too (meaning you lose everything). Instead, a
    cancel in the filename dialog should return you to the
    session (unclosed) with the editor contents unsaved.

    Of course, as it stands, it is perfectly workable... this
    would just be a slight improvement for indecisive folks like
    myself :-)

     
  • Rob Manning

    Rob Manning - 2006-03-23

    Logged In: YES
    user_id=1287991

    Oh dear, yes I see that would be very inconvenient if it
    happened to me. It's a valid point. I'll try to get a
    fix in for it soon.

    Rob

     
  • eagle79

    eagle79 - 2006-03-23

    Logged In: YES
    user_id=1300245

    Thanks so much! :-)

     
  • Rob Manning

    Rob Manning - 2006-03-23

    Logged In: YES
    user_id=1287991

    Fixed in CVS. Will be available in this weekend's snapshot.

     
  • Rob Manning

    Rob Manning - 2006-03-23
    • status: open --> pending-fixed
     
  • SourceForge Robot

    • status: pending-fixed --> closed-fixed
     
  • SourceForge Robot

    Logged In: YES
    user_id=1312539

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     

Log in to post a comment.