Hi Tim,
A few questions:
* What are current VMs supposed to fill for "windowIndex" in the events?
* Why a "SmallInt" window index if the field allows for a full 32bit value?
(this would be extremely advantageous on windows as we could just use
HANDLE value which I would absolutely want to use for a variety of reasons)
* What's a "WindowEventStinks"? Who would signal it and under which
condition? (I have never heard of that before)
Otherwise it looks good to me.
Cheers,
- Andreas
----- Original Message -----
From: "Tim Rowledge" <ti...@su...>
To: <squ...@li...>
Sent: Tuesday, December 07, 2004 10:46 AM
Subject: [Squeak-VMdev] Proposed small changes to some Cross files
> I'd like some yay/nay opinions on committing the attached small changes
> to sq.h et al. for the Ffenestri support. I can't see any chance of them
> causing damage but I try to be polite about these things when possible.
>
> One change is purely for RISC OS now that the CC has long long support,
> another is simply a comment change about timers (following on from the
> cached primitive function pointers changes) and the last is adding some
> event types for Ffenestri.
>
> If I don't hear any valid screams by the end of today I'll commit them
> to the SVN repository tonight and we'll see what happens.
>
> tim
> --
> Tim Rowledge, ti...@su..., http://sumeru.stanford.edu/tim
> Useful random insult:- Parked his head and forgot where he left it.
>
|
