Re: [Squeak-Commits] [CVS] squeak/platforms/unix/vm sqXWindow.c,1.27,1.28

[Lex S. <le...@cc...>]

Bert Freudenberg <be...@is...> wrote:
> On Mon, 11 Mar 2002, Lex Spoon wrote:
> 
> > Update of /cvsroot/squeak/squeak/platforms/unix/vm
> > In directory usw-pr-cvs1:/tmp/cvs-serv5658
> > 
> > Modified Files:
> > 	sqXWindow.c 
> > Log Message:
> > only modify buttonState from one location.
> 
> Hi Lex, 
> 
> while you're hacking: it should be width/height instead of 
> ec->width/height here:
> 
> 	  if (! fullScreen)
> 	    {
> 	      XResizeWindow(stDisplay, stWindow, width, height);
> 	      stWindowWidth= width;
> 	      stWindowHeight= height;
> 	    }
> 

Ah, right.  It probably doesn't matter, but it may as well be done
right.


> And I get sometimes hangs here (I'm, not sure why, only as browser 
> plugin, only in Netscape 4, but not always):
> 
>     completionType= XShmGetEventBase(stDisplay) + ShmCompletion;
> 
> At least we should wrap this into
> 
>     if (useXshm)
> 
> otherwise it's even performed when no Xshm is available/selected.


You are right.  I always run with XSHM.

As far as hanging on completions, I see it in other places but don't
know why.  I don't even know what it's *supposed* to be doing....


-Lex