Re: [Squeak-VMdev] Cleaning up Interpreter>writeImage:

[John M M. <jo...@sm...>]

On the mac I do
char *getImageName(void) {}
void SetImageNameViaString(char *string,UInt32 encoding) {}

and provide character set encoding information, so I never refer to the  
global directly, rather only thru methods that consider the
character encoding the VM is set to use.


On Nov 23, 2004, at 7:28 PM, Tim Rowledge wrote:

> In a similar vein to my previous email, I'd like to make a small
> cleanup in the writeImage code - it currently refers directly to
> 'imageName'. This feels nasty since it's not an ivar, a temp or
> anything accessible to the slang code - it's a C global kept mostly in
> blahMain.c or wherever. It just makes me cringe when I see it.
>
> We already have a prototype for a nice little getter function in sq.h,
> so could we try using
> char * getImageName(void); ?
>
> All it needs to be is
> char * getImageName(void) {
> 	return imageName;
> }
>
>
> tim
> --
> Tim Rowledge, ti...@su..., http://sumeru.stanford.edu/tim
> Strange OpCodes: ESR: Emulate Slide Rule
>
>
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real  
> users.
> Discover which products truly live up to the hype. Start reading now.
> http://productguide.itmanagersjournal.com/
> _______________________________________________
> Squeak-VMdev mailing list
> Squ...@li...
> https://lists.sourceforge.net/lists/listinfo/squeak-vmdev
>
>
--
======================================================================== 
===
John M. McIntosh <jo...@sm...> 1-800-477-2659
Corporate Smalltalk Consulting Ltd.  http://www.smalltalkconsulting.com
======================================================================== 
===