Menu

#17 Fix for password hiding pipe problems

v2.4
closed-fixed
None
5
2014-03-22
2009-02-17
David Wood
No

[ patch courtesy Yichen Xie ]

Hello,

Thank you for the password hiding code introduced in sqsh 2.1.4. There are two problems with this feature:

1) it assumes file descriptor 3 which breaks applications already using this file descriptor. One example is http://invisible-island.net/xterm/.

2) a hang is possible if the password is long but the pipe buffer is short.

The following patch was generated against 2.1.4 but it should apply cleanly against 2.1.5.

David

Discussion

  • David Wood

    David Wood - 2009-02-17

    patch.txt

     
  • David Wood

    David Wood - 2010-01-26

    Patch against v2.1.6

     
  • David Wood

    David Wood - 2010-01-26

    Hello,

    I've uploaded a patch against v2.1.6. David

     
  • Martin Wesdorp

    Martin Wesdorp - 2010-01-26

    Hi David,

    I just incorporated your patch as part of the upcoming sqsh-2.1.7 release.

    Thanks,
    Martin.

     
  • Martin Wesdorp

    Martin Wesdorp - 2013-04-23

    Fixed in sqsh-2.1.7 and improved in upcoming release sqsh-2.2.0

     
  • Martin Wesdorp

    Martin Wesdorp - 2013-04-23
    • status: open --> closed
     
  • Martin Wesdorp

    Martin Wesdorp - 2014-03-22
    • status: closed --> closed-fixed
    • assigned_to: Martin Wesdorp
    • Group: --> v2.4
     

Log in to post a comment.

MongoDB Logo MongoDB